✨ v3 (feature): merge Listen methods & ListenConfig (#1930)

* ✨ v3: new Start method for app

* ✨ v3: new Start method for app

* ✨ v3: new Start method for app

* ✨ v3: new Start method for app

* ✨ v3: new Start method for app

* ✨ v3: new Start method for app

* fix tests

* improve graceful shutdown

* update

* Start -> Listen

* rename test funcs.

* Add Test_Listen_Graceful_Shutdown test.

* add OnShutdownSuccess

* fix tests

* fix tests

* split listen & listener

* typo

* Add retry logic to tests

* Add retry logic to tests

* Add retry logic to tests

* Add retry logic to tests

Co-authored-by: René Werner <[email protected]>

Author: efectn

.github/workflows/test.yml

@@ -35,4 +35,8 @@ jobs:
     - name: Fetch Repository
       uses: actions/checkout@v3
     - name: Run Test
-      run: go test ./... -v -race
+      uses: nick-fields/retry@v2
+      with:
+        max_attempts: 3
+        timeout_minutes: 15
+        command: go test ./... -v -race

app.go

@@ -124,11 +124,6 @@ type App struct {
 
 // Config is a struct holding the server settings.
 type Config struct {
-	// When set to true, this will spawn multiple Go processes listening on the same port.
-	//
-	// Default: false
-	Prefork bool `json:"prefork"`
-
 	// Enables the "Server: value" HTTP header.
 	//
 	// Default: ""
@@ -270,11 +265,6 @@ type Config struct {
 	// Default: false
 	DisableHeaderNormalizing bool `json:"disable_header_normalizing"`
 
-	// When set to true, it will not print out the «Fiber» ASCII art and listening address.
-	//
-	// Default: false
-	DisableStartupMessage bool `json:"disable_startup_message"`
-
 	// This function allows to setup app name for the app
 	//
 	// Default: nil
@@ -332,12 +322,6 @@ type Config struct {
 	// Default: xml.Marshal
 	XMLEncoder utils.XMLMarshal `json:"-"`
 
-	// Known networks are "tcp", "tcp4" (IPv4-only), "tcp6" (IPv6-only)
-	// WARNING: When prefork is set to true, only "tcp4" and "tcp6" can be chose.
-	//
-	// Default: NetworkTCP4
-	Network string
-
 	// If you find yourself behind some sort of proxy, like a load balancer,
 	// then certain header information may be sent to you using special X-Forwarded-* headers or the Forwarded header.
 	// For example, the Host HTTP header is usually used to return the requested host.
@@ -374,10 +358,6 @@ type Config struct {
 	// Default: false
 	EnableIPValidation bool `json:"enable_ip_validation"`
 
-	// If set to true, will print all routes with their method, path and handler.
-	// Default: false
-	EnablePrintRoutes bool `json:"enable_print_routes"`
-
 	// You can define custom color scheme. They'll be used for startup message, route list and some middlewares.
 	//
 	// Optional. Default: DefaultColors
@@ -533,9 +513,6 @@ func New(config ...Config) *App {
 	if app.config.XMLEncoder == nil {
 		app.config.XMLEncoder = xml.Marshal
 	}
-	if app.config.Network == "" {
-		app.config.Network = NetworkTCP4
-	}
 
 	app.config.trustedProxiesMap = make(map[string]struct{}, len(app.config.TrustedProxies))
 	for _, ipAddress := range app.config.TrustedProxies {
@@ -831,7 +808,8 @@ func (app *App) HandlersCount() uint32 {
 // Shutdown does not close keepalive connections so its recommended to set ReadTimeout to something else than 0.
 func (app *App) Shutdown() error {
 	if app.hooks != nil {
-		defer app.hooks.executeOnShutdownHooks()
+		// TODO: check should be defered?
+		app.hooks.executeOnShutdownHooks()
 	}
 
 	app.mutex.Lock()

app_test.go

@@ -599,16 +599,14 @@ func Test_App_New(t *testing.T) {
 
 func Test_App_Config(t *testing.T) {
 	app := New(Config{
-		DisableStartupMessage: true,
+		StrictRouting: true,
 	})
-	require.True(t, app.Config().DisableStartupMessage)
+	require.True(t, app.Config().StrictRouting)
 }
 
 func Test_App_Shutdown(t *testing.T) {
 	t.Run("success", func(t *testing.T) {
-		app := New(Config{
-			DisableStartupMessage: true,
-		})
+		app := New()
 		require.True(t, app.Shutdown() == nil)
 	})
 
@@ -1098,7 +1096,6 @@ func Test_App_Deep_Group(t *testing.T) {
 // go test -run Test_App_Next_Method
 func Test_App_Next_Method(t *testing.T) {
 	app := New()
-	app.config.DisableStartupMessage = true
 
 	app.Use(func(c Ctx) error {
 		require.Equal(t, MethodGet, c.Method())
@@ -1140,7 +1137,6 @@ func Test_NewError(t *testing.T) {
 // go test -run Test_Test_Timeout
 func Test_Test_Timeout(t *testing.T) {
 	app := New()
-	app.config.DisableStartupMessage = true
 
 	app.Get("/", testEmptyHandler)
 
@@ -1166,7 +1162,6 @@ func (errorReader) Read([]byte) (int, error) {
 // go test -run Test_Test_DumpError
 func Test_Test_DumpError(t *testing.T) {
 	app := New()
-	app.config.DisableStartupMessage = true
 
 	app.Get("/", testEmptyHandler)
 
@@ -1236,10 +1231,9 @@ func Test_App_HandlersCount(t *testing.T) {
 // go test -run Test_App_ReadTimeout
 func Test_App_ReadTimeout(t *testing.T) {
 	app := New(Config{
-		ReadTimeout:           time.Nanosecond,
-		IdleTimeout:           time.Minute,
-		DisableStartupMessage: true,
-		DisableKeepalive:      true,
+		ReadTimeout:      time.Nanosecond,
+		IdleTimeout:      time.Minute,
+		DisableKeepalive: true,
 	})
 
 	app.Get("/read-timeout", func(c Ctx) error {
@@ -1266,14 +1260,12 @@ func Test_App_ReadTimeout(t *testing.T) {
 		require.Nil(t, app.Shutdown())
 	}()
 
-	require.Nil(t, app.Listen(":4004"))
+	require.Nil(t, app.Listen(":4004", ListenConfig{DisableStartupMessage: true}))
 }
 
 // go test -run Test_App_BadRequest
 func Test_App_BadRequest(t *testing.T) {
-	app := New(Config{
-		DisableStartupMessage: true,
-	})
+	app := New()
 
 	app.Get("/bad-request", func(c Ctx) error {
 		return c.SendString("I should not be sent")
@@ -1298,14 +1290,13 @@ func Test_App_BadRequest(t *testing.T) {
 		require.Nil(t, app.Shutdown())
 	}()
 
-	require.Nil(t, app.Listen(":4005"))
+	require.Nil(t, app.Listen(":4005", ListenConfig{DisableStartupMessage: true}))
 }
 
 // go test -run Test_App_SmallReadBuffer
 func Test_App_SmallReadBuffer(t *testing.T) {
 	app := New(Config{
-		ReadBufferSize:        1,
-		DisableStartupMessage: true,
+		ReadBufferSize: 1,
 	})
 
 	app.Get("/small-read-buffer", func(c Ctx) error {
@@ -1322,7 +1313,7 @@ func Test_App_SmallReadBuffer(t *testing.T) {
 		require.Nil(t, app.Shutdown())
 	}()
 
-	require.Nil(t, app.Listen(":4006"))
+	require.Nil(t, app.Listen(":4006", ListenConfig{DisableStartupMessage: true}))
 }
 
 func Test_App_Server(t *testing.T) {