Skip to content

Conversation

@jarlandre
Copy link

@jarlandre jarlandre commented Jan 20, 2023

  • denying client credentials grant if client is public
  • adjusting tests to make different clients based on whether or not they are public
  • this will allow for using public grants like authorisation code flow with client_secret not set on client and Public set to true
  • if libraries implement this and dont want to care about it they can just return false for IsPublic (i forked go-oauth2-pg and changed it to contain public field in db)

@LyricTian LyricTian marked this pull request as ready for review February 3, 2023 02:53
@LyricTian LyricTian merged commit 8f0d487 into go-oauth2:master Feb 3, 2023
@jarlandre jarlandre deleted the supportPublicGrantsWithIsPublicFunction branch February 3, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants