Skip to content

Conversation

@jbottigliero
Copy link
Member

@jbottigliero jbottigliero commented Jan 3, 2025

  • Updates the structure of how tokens are stored on the configured storage system to allow retrieval by scope when necessary.
  • This change allows for multiple tokens, for the same resource server, with different scopes to be managed. This was limitation of storing tokens by {CLIENT_ID}:{RESOURCE_SERVER}.
  • AuthorizationManager.getGlobusAuthToken() and AuthorizationManager.hasGlobusAuthToken() have been deprecated; Use AuthorizationManager.tokens.auth instead.
  • BREAKING CHANGE The authenticated event no longer provides a token as part of the event payload. Originally, this would only provide the Globus Auth token, but your application might never require a Globus Auth token (and only tokens from a specific service).

This has been marked as a breaking change based on the structure change to how tokens are stored; This would only be a breaking change if you are accessing stored tokens in localStorage or sessionStorage directly, which is not advised (use the TokenManager instance instead).

@jbottigliero jbottigliero force-pushed the chore-TokenStorage branch 6 times, most recently from 9a26015 to d9e00ba Compare January 6, 2025 19:25
@codecov
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 83.13253% with 14 lines in your changes missing coverage. Please review.

Project coverage is 96.79%. Comparing base (9bc2478) to head (d9e00ba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/authorization/TokenManager.ts 83.78% 11 Missing and 1 partial ⚠️
src/core/authorization/AuthorizationManager.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   98.82%   96.79%   -2.04%     
==========================================
  Files          70       70              
  Lines        1191     1247      +56     
  Branches      194      208      +14     
==========================================
+ Hits         1177     1207      +30     
- Misses         14       39      +25     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbottigliero jbottigliero marked this pull request as draft January 10, 2025 17:56
- Updates the structure of how tokens are stored on the configured storage system to allow retrieval by scope when necessary.
- **Allows for multiple tokens, for the same resource server, with different scopes to be stored.**
@jbottigliero jbottigliero force-pushed the chore-TokenStorage branch 2 times, most recently from 073bab0 to 8dea668 Compare October 10, 2025 15:19
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 93.97590% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.60%. Comparing base (10d97b1) to head (0968682).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/core/authorization/TokenManager.ts 93.24% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   94.89%   94.60%   -0.29%     
==========================================
  Files          75       75              
  Lines        1411     1465      +54     
  Branches      227      241      +14     
==========================================
+ Hits         1339     1386      +47     
- Misses         71       78       +7     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants