Skip to content

Commit a4baac6

Browse files
nezhafanvoyager1
andauthored
refactor(context):Avoid using filepath.Dir twice in SaveUploadedFile (#4181)
Co-authored-by: voyager1 <[email protected]>
1 parent 1eb8272 commit a4baac6

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

context.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -684,15 +684,15 @@ func (c *Context) SaveUploadedFile(file *multipart.FileHeader, dst string, perm
684684
}
685685
defer src.Close()
686686

687-
if len(perm) <= 0 {
688-
perm = append(perm, 0o750)
687+
var mode os.FileMode = 0o750
688+
if len(perm) > 0 {
689+
mode = perm[0]
689690
}
690-
691-
if err = os.MkdirAll(filepath.Dir(dst), perm[0]); err != nil {
691+
dir := filepath.Dir(dst)
692+
if err = os.MkdirAll(dir, mode); err != nil {
692693
return err
693694
}
694-
695-
if err = os.Chmod(filepath.Dir(dst), perm[0]); err != nil {
695+
if err = os.Chmod(dir, mode); err != nil {
696696
return err
697697
}
698698

0 commit comments

Comments
 (0)