Skip to content

Commit a15269e

Browse files
authored
Merge pull request #1679 from zewa666/cell-range-decorator-darkmode
feat: matching border color for range selector in darkmode
2 parents 075d191 + 53d0aa2 commit a15269e

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

packages/common/src/core/__tests__/slickGrid.spec.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1159,6 +1159,15 @@ describe('SlickGrid core file', () => {
11591159

11601160
expect(rowSelectSpy).toHaveBeenCalled();
11611161
});
1162+
1163+
it('should change border color for darkMode', () => {
1164+
const cellSelectionModel = new SlickCellSelectionModel();
1165+
1166+
grid = new SlickGrid<any, Column>(container, [], columns, { ...defaultOptions, darkMode: true });
1167+
cellSelectionModel.init(grid);
1168+
1169+
expect(cellSelectionModel.cellRangeSelector.addonOptions.selectionCss.border).toBe('2px solid white');
1170+
});
11621171
});
11631172

11641173
describe('Node Getters', () => {
@@ -5813,4 +5822,4 @@ describe('SlickGrid core file', () => {
58135822
});
58145823
});
58155824
});
5816-
});
5825+
});

packages/common/src/extensions/slickCellSelectionModel.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ export class SlickCellSelectionModel implements SelectionModel {
5252

5353
init(grid: SlickGrid): void {
5454
this._grid = grid;
55+
if (this._addonOptions === undefined || this._addonOptions.cellRangeSelector === undefined) {
56+
this._selector = new SlickCellRangeSelector({ selectionCss: { border: `2px solid ${this._grid.getOptions().darkMode ? "white" : "black"}` } as CSSStyleDeclaration })
57+
}
58+
5559
if (grid.hasDataView()) {
5660
this._dataView = grid.getData<CustomDataView | SlickDataView>();
5761
}

0 commit comments

Comments
 (0)