chore(commits): Remove update_commit dual write function (#102180)

We're no longer planning on using the dual written tables, so removing
these functions

Author: wedamija

src/sentry/integrations/utils/commit_context.py

@@ -28,8 +28,7 @@
 from sentry.models.commit import Commit
 from sentry.models.commitauthor import CommitAuthor
 from sentry.models.organization import Organization
-from sentry.releases.commits import create_commit, update_commit
-from sentry.releases.models import Commit as NewCommit
+from sentry.releases.commits import create_commit
 from sentry.shared_integrations.exceptions import ApiError
 from sentry.utils import metrics
 from sentry.utils.committers import get_stacktrace_path_from_event_frame
@@ -140,9 +139,7 @@ def get_or_create_commit_from_blame(
             key=blame.commit.commitId,
         )
         if commit.message == "":
-            new_commit = NewCommit.objects.get(id=commit.id)
-            update_commit(commit, new_commit, message=blame.commit.commitMessage)
-
+            commit.update(message=blame.commit.commitMessage)
         return commit
     except Commit.DoesNotExist:
         logger.info(

src/sentry/models/releases/set_commits.py

@@ -34,11 +34,7 @@
 from sentry.models.releaseheadcommit import ReleaseHeadCommit
 from sentry.models.repository import Repository
 from sentry.plugins.providers.repository import RepositoryProvider
-from sentry.releases.commits import (
-    bulk_create_commit_file_changes,
-    get_or_create_commit,
-    update_commit,
-)
+from sentry.releases.commits import bulk_create_commit_file_changes, get_or_create_commit
 
 
 class _CommitDataKwargs(TypedDict, total=False):
@@ -138,7 +134,7 @@ def set_commit(idx, data, release):
         date_added=commit_data.get("date_added"),  # type: ignore[arg-type]
     )
     if not created and any(getattr(commit, key) != value for key, value in commit_data.items()):
-        update_commit(commit, new_commit, **commit_data)
+        commit.update(**commit_data)
 
     if author is None:
         author = commit.author

src/sentry/releases/commits.py

@@ -128,18 +128,6 @@ def get_or_create_commit(
     return old_commit, new_commit, created
 
 
-def update_commit(old_commit: OldCommit, new_commit: Commit, **fields) -> None:
-    """Update a commit in both tables if dual write is enabled."""
-    with atomic_transaction(
-        using=(
-            router.db_for_write(OldCommit),
-            router.db_for_write(Commit),
-        )
-    ):
-        old_commit.update(**fields)
-        new_commit.update(**fields)
-
-
 def bulk_create_commit_file_changes(
     file_changes: list[OldCommitFileChange],
 ) -> tuple[list[OldCommitFileChange], list[CommitFileChange]]:

tests/sentry/releases/test_commits.py

@@ -14,7 +14,6 @@
     create_commit,
     get_dual_write_start_date,
     get_or_create_commit,
-    update_commit,
 )
 from sentry.releases.models import Commit, CommitFileChange
 from sentry.testutils.cases import TestCase
@@ -241,73 +240,6 @@ def test_get_or_create_commit_backfills_to_new_table(self):
         assert new_commit.author == self.author
 
 
-class UpdateCommitTest(TestCase):
-    def setUp(self):
-        super().setUp()
-        self.repo = Repository.objects.create(
-            name="test-repo",
-            organization_id=self.organization.id,
-        )
-        self.author = CommitAuthor.objects.create(
-            organization_id=self.organization.id,
-            email="[email protected]",
-            name="Test Author",
-        )
-
-    def test_update_commit_with_dual_write(self):
-        """Test updating a commit updates both tables when new_commit is provided"""
-        old_commit = OldCommit.objects.create(
-            organization_id=self.organization.id,
-            repository_id=self.repo.id,
-            key="abc123",
-            message="Initial message",
-            author=self.author,
-        )
-        new_commit = Commit.objects.create(
-            id=old_commit.id,
-            organization_id=self.organization.id,
-            repository_id=self.repo.id,
-            key="abc123",
-            message="Initial message",
-            author=self.author,
-            date_added=old_commit.date_added,
-        )
-        update_commit(old_commit, new_commit, message="Updated message")
-        old_commit.refresh_from_db()
-        new_commit.refresh_from_db()
-        assert old_commit.message == "Updated message"
-        assert new_commit.message == "Updated message"
-
-    def test_update_commit_atomic_transaction(self):
-        """Test that updates are atomic when dual write is enabled"""
-        old_commit = OldCommit.objects.create(
-            organization_id=self.organization.id,
-            repository_id=self.repo.id,
-            key="ghi789",
-            message="Initial message",
-            author=self.author,
-        )
-        new_commit = Commit.objects.create(
-            id=old_commit.id,
-            organization_id=self.organization.id,
-            repository_id=self.repo.id,
-            key="ghi789",
-            message="Initial message",
-            author=self.author,
-            date_added=old_commit.date_added,
-        )
-        with (
-            patch.object(Commit, "update", side_effect=Exception("Update failed")),
-            pytest.raises(Exception, match="Update failed"),
-        ):
-            update_commit(old_commit, new_commit, message="Should fail")
-
-        old_commit.refresh_from_db()
-        new_commit.refresh_from_db()
-        assert old_commit.message == "Initial message"
-        assert new_commit.message == "Initial message"
-
-
 class CreateCommitFileChangeDualWriteTest(TestCase):
     def setUp(self):
         super().setUp()