overwrite

Author: bitsandfoxes

src/Sentry.Unity.Editor/Android/AndroidManifestConfiguration.cs

@@ -228,13 +228,22 @@ internal void CopyAndroidSdkToGradleProject(string unityProjectPath, string grad
                 throw new DirectoryNotFoundException($"Failed to find the Android SDK at '{androidSdkPath}'.");
             }
 
+            Directory.CreateDirectory(targetPath);
+
             _logger.LogInfo("Copying the Android SDK to '{0}'.", gradlePath);
             foreach (var file in Directory.GetFiles(androidSdkPath))
             {
                 var destinationFile = Path.Combine(targetPath, Path.GetFileName(file));
-                if (!File.Exists(destinationFile))
+                
+                try 
+                {
+                    File.Copy(file, destinationFile, overwrite: true);
+                    _logger.LogDebug("Copied SDK file: {0}", Path.GetFileName(file));
+                }
+                catch (Exception e)
                 {
-                    File.Copy(file, destinationFile);
+                    _logger.LogError(e, "Failed to copy SDK file: {0}", Path.GetFileName(file));
+                    throw;
                 }
             }
         }

test/Sentry.Unity.Editor.Tests/Android/AndroidManifestConfigurationTests.cs

@@ -421,6 +421,28 @@ public void CopyAndroidSdkToGradleProject_AndroidNativeSupportDisabledButSdkAlre
         Directory.Delete(fakeProjectPath, true);
     }
 
+    [Test]
+    public void CopyAndroidSdkToGradleProject_SdkAlreadyExists_OverwritesExistingSdk()
+    {
+        var fakeProjectPath = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
+        var unityProjectPath = Path.Combine(fakeProjectPath, "UnityProject");
+        var gradleProjectPath = Path.Combine(fakeProjectPath, "GradleProject");
+        DebugSymbolUploadTests.SetupFakeProject(fakeProjectPath);
+
+        var targetPath = Path.Combine(gradleProjectPath, "unityLibrary", "libs");
+        Directory.CreateDirectory(targetPath);
+        var existingFile = Path.Combine(targetPath, "androidSdk.jar");
+        File.WriteAllText(existingFile, "original content");
+
+        var sut = _fixture.GetSut();
+        sut.CopyAndroidSdkToGradleProject(unityProjectPath, gradleProjectPath);
+
+        var newContent = File.ReadAllBytes(existingFile);
+        Assert.AreNotEqual("original content", System.Text.Encoding.UTF8.GetString(newContent));
+
+        Directory.Delete(fakeProjectPath, true);
+    }
+
     private string WithAndroidManifest(Action<string> callback)
     {
         var basePath = GetFakeManifestFileBasePath();