fix: catch errors thrown during handleBeginFrame and handleDrawFrame (#2446)

* fix

* update CHANGELOG

* rethrow in automatedTestMode

Author: buenaflor

CHANGELOG.md

@@ -52,6 +52,7 @@
 
 ### Fixes
 
+- Catch errors thrown during `handleBeginFrame` and `handleDrawFrame` ([#2446](https://github.com/getsentry/sentry-dart/pull/2446))
 - OS & device contexts missing on Windows ([#2439](https://github.com/getsentry/sentry-dart/pull/2439))
 - Native iOS/macOS SDK session didn't start after Flutter hot-restart ([#2452](https://github.com/getsentry/sentry-dart/pull/2452))
 

flutter/lib/src/binding_wrapper.dart

@@ -1,11 +1,11 @@
 // ignore_for_file: invalid_use_of_internal_member
 
 import 'package:flutter/foundation.dart';
-
-import '../sentry_flutter.dart';
 import 'package:flutter/widgets.dart';
 import 'package:meta/meta.dart';
 
+import '../sentry_flutter.dart';
+
 /// The methods and properties are modelled after the the real binding class.
 @experimental
 class BindingWrapper {
@@ -88,6 +88,8 @@ mixin SentryWidgetsBindingMixin on WidgetsBinding {
   FrameTimingCallback? _frameTimingCallback;
   ClockProvider? _clock;
 
+  SentryOptions get _options => Sentry.currentHub.options;
+
   @internal
   void registerFramesTracking(
       FrameTimingCallback callback, ClockProvider clock) {
@@ -108,7 +110,13 @@ mixin SentryWidgetsBindingMixin on WidgetsBinding {
 
   @override
   void handleBeginFrame(Duration? rawTimeStamp) {
-    _startTimestamp = _clock?.call();
+    try {
+      _startTimestamp = _clock?.call();
+    } catch (_) {
+      if (_options.automatedTestMode) {
+        rethrow;
+      }
+    }
 
     super.handleBeginFrame(rawTimeStamp);
   }
@@ -117,11 +125,17 @@ mixin SentryWidgetsBindingMixin on WidgetsBinding {
   void handleDrawFrame() {
     super.handleDrawFrame();
 
-    final endTimestamp = _clock?.call();
-    if (_startTimestamp != null &&
-        endTimestamp != null &&
-        _startTimestamp!.isBefore(endTimestamp)) {
-      _frameTimingCallback?.call(_startTimestamp!, endTimestamp);
+    try {
+      final endTimestamp = _clock?.call();
+      if (_startTimestamp != null &&
+          endTimestamp != null &&
+          _startTimestamp!.isBefore(endTimestamp)) {
+        _frameTimingCallback?.call(_startTimestamp!, endTimestamp);
+      }
+    } catch (_) {
+      if (_options.automatedTestMode) {
+        rethrow;
+      }
     }
   }
 }

flutter/test/sentry_flutter_widgets_binding_test.dart

@@ -0,0 +1,50 @@
+import 'package:flutter_test/flutter_test.dart';
+import 'package:sentry_flutter/src/binding_wrapper.dart';
+
+import 'binding.dart';
+
+void main() {
+  // Make sure whatever error happens during the frame processing we catch it
+  // Otherwise it would disrupt the frame processing and freeze the UI
+  group('$SentryWidgetsBindingMixin', () {
+    late SentryAutomatedTestWidgetsFlutterBinding binding;
+
+    setUp(() {
+      binding = SentryAutomatedTestWidgetsFlutterBinding.ensureInitialized();
+      // reset state
+      binding.removeFramesTracking();
+    });
+
+    test('frame processing continues execution when clock throws', () {
+      binding.registerFramesTracking(
+        (_, __) {},
+        () => throw Exception('Clock error'),
+      );
+
+      expect(
+        () {
+          binding.handleBeginFrame(null);
+          binding.handleDrawFrame();
+        },
+        returnsNormally,
+      );
+    });
+
+    test('frame processing execution when callback throws', () {
+      binding.registerFramesTracking(
+        (_, __) {
+          throw Exception('Callback error');
+        },
+        () => DateTime.now(),
+      );
+
+      expect(
+        () {
+          binding.handleBeginFrame(null);
+          binding.handleDrawFrame();
+        },
+        returnsNormally,
+      );
+    });
+  });
+}