Skip to content

Commit 20a5bce

Browse files
authored
fix: iOS warning of missing method channel callback setReplayConfig (#2478)
1 parent ab99a31 commit 20a5bce

File tree

3 files changed

+18
-7
lines changed

3 files changed

+18
-7
lines changed

flutter/lib/src/native/cocoa/sentry_native_cocoa.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1+
import 'dart:async';
12
import 'dart:ffi';
23
import 'dart:typed_data';
34
import 'dart:ui';
45

56
import 'package:meta/meta.dart';
67

78
import '../../../sentry_flutter.dart';
9+
import '../../replay/replay_config.dart';
810
import '../../screenshot/recorder.dart';
911
import '../../screenshot/recorder_config.dart';
1012
import '../sentry_native_channel.dart';
@@ -68,6 +70,11 @@ class SentryNativeCocoa extends SentryNativeChannel {
6870
return super.init(hub);
6971
}
7072

73+
@override
74+
FutureOr<void> setReplayConfig(ReplayConfig config) {
75+
// Note: unused on iOS.
76+
}
77+
7178
@override
7279
int? startProfiler(SentryId traceId) => tryCatchSync('startProfiler', () {
7380
final cSentryId = cocoa.SentryId1.alloc(_lib)

flutter/lib/src/native/sentry_native_channel.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ class SentryNativeChannel
221221
bool get supportsReplay => false;
222222

223223
@override
224-
Future<void> setReplayConfig(ReplayConfig config) =>
224+
FutureOr<void> setReplayConfig(ReplayConfig config) =>
225225
channel.invokeMethod('setReplayConfig', {
226226
'width': config.width,
227227
'height': config.height,

flutter/test/sentry_native_channel_test.dart

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -335,12 +335,16 @@ void main() {
335335
ReplayConfig(width: 1.1, height: 2.2, frameRate: 3, bitRate: 4);
336336
await sut.setReplayConfig(config);
337337

338-
verify(channel.invokeMethod('setReplayConfig', {
339-
'width': config.width,
340-
'height': config.height,
341-
'frameRate': config.frameRate,
342-
'bitRate': config.bitRate,
343-
}));
338+
if (mockPlatform.isAndroid) {
339+
verify(channel.invokeMethod('setReplayConfig', {
340+
'width': config.width,
341+
'height': config.height,
342+
'frameRate': config.frameRate,
343+
'bitRate': config.bitRate,
344+
}));
345+
} else {
346+
verifyNever(channel.invokeMethod('setReplayConfig', any));
347+
}
344348
});
345349

346350
test('captureReplay', () async {

0 commit comments

Comments
 (0)