Merge pull request #46 from geigerzaehler/which

Don’t execute external program to determine if it is available

Author: geigerzaehler

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Upcoming
 
+- Don’t run custom external programs with `-v` (e.g. `ffmpeg -v`) to determine
+  whether they are available. (Fixes #43)
 - Require Python >=3.9
 
 ## v0.14.1 2024-07-11

beetsplug/check.py

@@ -13,6 +13,7 @@
 
 import os
 import re
+import shutil
 import sys
 from concurrent import futures
 from hashlib import sha256
@@ -510,16 +511,8 @@ def __init__(self, name, config):
         else:
             self.fixcmd = False
 
-    def available(self):
-        try:
-            with open(os.devnull, "wb") as devnull:
-                check_call(
-                    [self.cmdline.split(" ")[0], "-v"], stdout=devnull, stderr=devnull
-                )
-        except OSError:
-            return False
-        else:
-            return True
+    def available(self) -> bool:
+        return shutil.which(self.cmdline.split(" ")[0]) is not None
 
     @classmethod
     def fixer(cls, item):