we shall clean the commented out code

[prashant-andani]

Hey Folks !!!
I see that some of the code blocks are commented out, in the CSS, JS, HTML.

were they mean't to be kept? IMHO We must clean them up, to clear out that they are not required. And avoid accidentally uncommenting them and get it applied.

Let me know your opinions....

[DSchau]

@prashant-andani not really sure what you're referring to--could you provide an example of the commented code? Do you mean in the default starter?

[prashant-andani]

@DSchau The code has been commented mostly in the www folder
some of them are
i.e www/src/components/sidebar/accordion.js, evalution-table.js, creator-headers.js

[polarathene]

Ok, not comments for related code, but actual parts of code that aren't in use but have been kept as commented out code.

accordion.js#L128, git blame to spring clean ep 5 PR
evaluation-table.js#L28, git blame to spring clean ep 2 PR

I imagine any of the other ones you've seen also have a good chance of git blame pointing to related PRs.

Perhaps @fk can clarify what's going on there and if they're safe to remove or kept around for a reason like that intentionally :)

[wardpeet]

feel free to cleanup, it's just how @fk works ;)

[fk]

👋 Yep, I'm a total mess! :D

@prashant-andani + @polarathene I once learned that no dead code — commented or not — should be commited in any case. Irt the sidebar accordions it somewhat made sense because that was kind of a moving target, but in general we (and esp. I 😬) should stick to the rule I just mentioned.
So as @wardpeet already said — feel free to clean up, any help is appreciated! Happy to review any PRs doing so, please just ping me! 🙏

[prashant-andani]

Ok, not comments for related code, but actual parts of code that aren't in use but have been kept as commented out code.

accordion.js#L128, git blame to spring clean ep 5 PR
evaluation-table.js#L28, git blame to spring clean ep 2 PR

I imagine any of the other ones you've seen also have a good chance of git blame pointing to related PRs.

Perhaps @fk can clarify what's going on there and if they're safe to remove or kept around for a reason like that intentionally :)

Thanks for correcting me out there .... "Commented out code" not "Commented Code"

[prashant-andani]

Cleaned up the commented out code... Hence closing this issue..