Skip to content

Conversation

@frano-m
Copy link
Contributor

@frano-m frano-m commented Apr 1, 2025

Closes #437.

image

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a "Launch Galaxy" feature to the workflow stepper by adding new props, hooks, and UI components to handle galaxy launch functionality. Key changes include updating component and type definitions to include “configuredInput” and “onConfigure”, implementing the useLaunchGalaxy hook to open the Galaxy landing page, and adjusting the Reference Assembly and GTF step components for the new functionality.

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
types.ts (Main & Stepper) Added new props (configuredInput, onConfigure) and updated key names (configKey → entryKey, label → entryLabel) to support launch galaxy logic.
main.tsx Modified to pass additional props to the Stepper component.
Stepper components Updated types and component props to propagate new launch functionality.
ReferenceAssemblyStep Updated to trigger onConfigure with new keys during useEffect.
GTFStep and related hooks Introduced launch galaxy button, updated radio group handling, and refined gene model label mapping.
Hooks (UseLaunchGalaxy, UseUCSCFiles, UseRadioGroup) Added new custom hooks and utilities to facilitate the new workflow logic.
Button constants Added specific button styling for the new launch galaxy button.
Comments suppressed due to low confidence (2)

app/components/Entity/components/ConfigureWorkflowInputs/components/Main/components/Stepper/components/Step/GTFStep/gtfStep.tsx:50

  • Using '!!geneModelUrls' only checks for undefined and may be truthy even if the array is empty. Consider using 'geneModelUrls && geneModelUrls.length > 0' to ensure that the step is active only when there are gene model URLs available.
<Step active={active && !!geneModelUrls} completed={completed} index={index}>

app/components/Entity/components/ConfigureWorkflowInputs/components/Main/components/Stepper/components/Step/GTFStep/gtfStep.tsx:68

  • [nitpick] Consider using a unique value (e.g. the 'value' property) as the key instead of the array index to help React reliably identify list items.
<FormControlLabel key={i}

@frano-m frano-m moved this to Ready for Review in BRC development tasks Apr 1, 2025
@frano-m
Copy link
Contributor Author

frano-m commented Apr 1, 2025

Using '!!geneModelUrls' only checks for undefined and may be truthy even if the array is empty. Consider using 'geneModelUrls && geneModelUrls.length > 0' to ensure that the step is active only when there are gene model URLs available.

I'm keeping this check here, we need to render the Step if geneModelUrls.length > 0. The check for !!geneModelUrls is intentional; the fetch is pending and we are still waiting for values. While this is occurring, we do not want to "open" the step up.

Copy link
Collaborator

@NoopDog NoopDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @frano-m !

@NoopDog NoopDog merged commit a94c7b6 into main Apr 1, 2025
2 checks passed
@NoopDog NoopDog deleted the fran/437-launch branch April 1, 2025 06:38
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in BRC development tasks Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add Launch Galaxy button to workflow stepper

3 participants