* add change to allow blaze info to skip Starlark build settings that start with --no prefix (bazelbuild#16258)

Ryan Beasley · Googler · web-flow · commit ceed7f1a7263 · 2022-09-13T09:00:39.000-07:00
* add unit tests for both info and clean commands

PiperOrigin-RevId: 424863510

Co-authored-by: Googler &lt;noreply@google.com&gt;
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java b/src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java
@@ -333,7 +333,7 @@ public static Pair<ImmutableList<String>, ImmutableList<String>> removeStarlarkO
       String potentialStarlarkFlag = name.substring(2);
       // Check if the string uses the "no" prefix for setting boolean flags to false, trim
       // off "no" if so.
-      if (name.startsWith("no")) {
+      if (potentialStarlarkFlag.startsWith("no")) {
         potentialStarlarkFlag = potentialStarlarkFlag.substring(2);
       }
       // Check if the string contains a value, trim off the value if so.

Original file line number	Diff line number	Diff line change
`@@ -333,7 +333,7 @@ public static Pair<ImmutableList<String>, ImmutableList<String>> removeStarlarkO`
`333`	`333`	`String potentialStarlarkFlag = name.substring(2);`
`334`	`334`	`// Check if the string uses the "no" prefix for setting boolean flags to false, trim`
`335`	`335`	`// off "no" if so.`
`336`		`- if (name.startsWith("no")) {`
	`336`	`+ if (potentialStarlarkFlag.startsWith("no")) {`
`337`	`337`	`potentialStarlarkFlag = potentialStarlarkFlag.substring(2);`
`338`	`338`	`}`
`339`	`339`	`// Check if the string contains a value, trim off the value if so.`