refactor: replace process::exit with Result errors in ensure_ok

DeVikingMark · web-flow · commit 2d67702236aa · 2025-10-24T02:31:03.000+02:00
diff --git a/crates/forge/src/result.rs b/crates/forge/src/result.rs
@@ -167,8 +167,7 @@ impl TestOutcome {
         }
 
         if shell::is_quiet() || silent {
-            // TODO: Avoid process::exit
-            std::process::exit(1);
+            return Err(eyre::eyre!("Test failures detected: {} tests failed", failures));
         }
 
         sh_println!("\nFailing tests:")?;
@@ -201,8 +200,7 @@ impl TestOutcome {
             test_word
         )?;
 
-        // TODO: Avoid process::exit
-        std::process::exit(1);
+        Err(eyre::eyre!("Test failures detected: {} tests failed", failures))
     }
 
     /// Removes first test result, if any.

Original file line number	Diff line number	Diff line change
`@@ -167,8 +167,7 @@ impl TestOutcome {`
`167`	`167`	`}`
`168`	`168`
`169`	`169`	`if shell::is_quiet() \|\| silent {`
`170`		`- // TODO: Avoid process::exit`
`171`		`- std::process::exit(1);`
	`170`	`+ return Err(eyre::eyre!("Test failures detected: {} tests failed", failures));`
`172`	`171`	`}`
`173`	`172`
`174`	`173`	`sh_println!("\nFailing tests:")?;`
`@@ -201,8 +200,7 @@ impl TestOutcome {`
`201`	`200`	`test_word`
`202`	`201`	`)?;`
`203`	`202`
`204`		`- // TODO: Avoid process::exit`
`205`		`- std::process::exit(1);`
	`203`	`+ Err(eyre::eyre!("Test failures detected: {} tests failed", failures))`
`206`	`204`	`}`
`207`	`205`
`208`	`206`	`/// Removes first test result, if any.`