Fix clang-tidy warnings

foonathan · foonathan · commit 2b4693d22ec8 · 2025-01-07T20:36:00.000+01:00
diff --git a/include/lexy/_detail/config.hpp b/include/lexy/_detail/config.hpp
@@ -50,7 +50,7 @@ template <typename T>
 std::add_rvalue_reference_t<T> declval();
 
 template <typename T>
-constexpr void swap(T& lhs, T& rhs)
+constexpr void swap(T& lhs, T& rhs) noexcept
 {
     T tmp = LEXY_MOV(lhs);
     lhs   = LEXY_MOV(rhs);
diff --git a/include/lexy/_detail/memory_resource.hpp b/include/lexy/_detail/memory_resource.hpp
@@ -9,7 +9,7 @@
 #include <lexy/_detail/config.hpp>
 #include <new>
 
-#if 0
+#if 0 // NOLINT
 // Subset of the interface of std::pmr::memory_resource.
 class MemoryResource
 {
diff --git a/include/lexy/encoding.hpp b/include/lexy/encoding.hpp
@@ -12,7 +12,7 @@
 namespace lexy
 {
 /// The endianness used by an encoding.
-enum class encoding_endianness
+enum class encoding_endianness // NOLINT(performance-enum-size)
 {
     /// Little endian.
     little,
diff --git a/src/input/file.cpp b/src/input/file.cpp
@@ -6,7 +6,9 @@
 
 #include <cerrno>
 #include <cstdio>
+#include <lexy/_detail/assert.hpp>
 #include <lexy/_detail/buffer_builder.hpp>
+#include <lexy/input/buffer.hpp>
 
 #if defined(__unix__) || defined(__APPLE__)
 
@@ -68,7 +70,7 @@ lexy::file_error lexy::_detail::read_file(const char* path, file_callback cb, vo
         return get_file_error();
 
     auto off = ::lseek(fd, 0, SEEK_END);
-    if (off == static_cast<::off_t>(-1))
+    if (off == static_cast<decltype(off)>(-1))
         return lexy::file_error::os_error;
     auto size = static_cast<std::size_t>(off);
 
diff --git a/tests/doctest_main.cpp b/tests/doctest_main.cpp
@@ -1,8 +1,6 @@
 // Copyright (C) 2020-2024 Jonathan Müller and lexy contributors
 // SPDX-License-Identifier: BSL-1.0
 
-#include <lexy/_detail/config.hpp>
-
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include <doctest/doctest.h>
 
diff --git a/tests/lexy/detail/buffer_builder.cpp b/tests/lexy/detail/buffer_builder.cpp
@@ -3,6 +3,7 @@
 
 #include <lexy/_detail/buffer_builder.hpp>
 
+#include <cstring>
 #include <doctest/doctest.h>
 
 TEST_CASE("_detail::buffer_builder")
diff --git a/tests/lexy/detail/integer_sequence.cpp b/tests/lexy/detail/integer_sequence.cpp
@@ -4,6 +4,7 @@
 #include <lexy/_detail/integer_sequence.hpp>
 
 #include <doctest/doctest.h>
+#include <type_traits>
 
 TEST_CASE("_detail::integer_sequence")
 {

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ template <typename T>`
`50`	`50`	`std::add_rvalue_reference_t<T> declval();`
`51`	`51`
`52`	`52`	`template <typename T>`
`53`		`-constexpr void swap(T& lhs, T& rhs)`
	`53`	`+constexpr void swap(T& lhs, T& rhs) noexcept`
`54`	`54`	`{`
`55`	`55`	`T tmp = LEXY_MOV(lhs);`
`56`	`56`	`lhs = LEXY_MOV(rhs);`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`#include <lexy/_detail/config.hpp>`
`10`	`10`	`#include <new>`
`11`	`11`
`12`		`-#if 0`
	`12`	`+#if 0 // NOLINT`
`13`	`13`	`// Subset of the interface of std::pmr::memory_resource.`
`14`	`14`	`class MemoryResource`
`15`	`15`	`{`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`namespace lexy`
`13`	`13`	`{`
`14`	`14`	`/// The endianness used by an encoding.`
`15`		`-enum class encoding_endianness`
	`15`	`+enum class encoding_endianness // NOLINT(performance-enum-size)`
`16`	`16`	`{`
`17`	`17`	`/// Little endian.`
`18`	`18`	`little,`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`#include <lexy/_detail/integer_sequence.hpp>`
`5`	`5`
`6`	`6`	`#include <doctest/doctest.h>`
	`7`	`+#include <type_traits>`
`7`	`8`
`8`	`9`	`TEST_CASE("_detail::integer_sequence")`
`9`	`10`	`{`