Make compatible with Node 17.

Author: RubenVerborgh

.github/workflows/ci.yml

@@ -34,14 +34,14 @@ jobs:
           - '15.x'
           - '16.0'
           - '16.x'
+          - '17.0'
+          - '17.x'
     steps:
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
       - uses: actions/checkout@v2
-      - if: ${{ matrix.node-version == '4.x' || matrix.node-version == '6.0' }}
-        run: npm install [email protected] [email protected] [email protected] [email protected]
       - run: npm install
       - if: ${{ matrix.node-version == '4.x' }}
         run: npm install [email protected] [email protected] [email protected] [email protected]

index.js

@@ -18,7 +18,7 @@ events.forEach(function (event) {
 // Error types with codes
 var RedirectionError = createErrorType(
   "ERR_FR_REDIRECTION_FAILURE",
-  ""
+  "Redirected request failed"
 );
 var TooManyRedirectsError = createErrorType(
   "ERR_FR_TOO_MANY_REDIRECTS",
@@ -376,8 +376,17 @@ RedirectableRequest.prototype._processResponse = function (response) {
     var currentUrl = /^\w+:/.test(location) ? this._currentUrl :
       url.format(Object.assign(currentUrlParts, { host: currentHost }));
 
+    // Determine the URL of the redirection
+    var redirectUrl;
+    try {
+      redirectUrl = url.resolve(currentUrl, location);
+    }
+    catch (cause) {
+      this.emit("error", new RedirectionError(cause));
+      return;
+    }
+
     // Create the redirected request
-    var redirectUrl = url.resolve(currentUrl, location);
     debug("redirecting to", redirectUrl);
     this._isRedirect = true;
     var redirectUrlParts = url.parse(redirectUrl);
@@ -406,9 +415,7 @@ RedirectableRequest.prototype._processResponse = function (response) {
       this._performRequest();
     }
     catch (cause) {
-      var error = new RedirectionError("Redirected request failed: " + cause.message);
-      error.cause = cause;
-      this.emit("error", error);
+      this.emit("error", new RedirectionError(cause));
     }
   }
   else {
@@ -526,9 +533,15 @@ function removeMatchingHeaders(regex, headers) {
 }
 
 function createErrorType(code, defaultMessage) {
-  function CustomError(message) {
+  function CustomError(cause) {
     Error.captureStackTrace(this, this.constructor);
-    this.message = message || defaultMessage;
+    if (!cause) {
+      this.message = defaultMessage;
+    }
+    else {
+      this.message = defaultMessage + ": " + cause.message;
+      this.cause = cause;
+    }
   }
   CustomError.prototype = new Error();
   CustomError.prototype.constructor = CustomError;

test/assets/TestCA.crt

@@ -0,0 +1,16 @@
+-----BEGIN CERTIFICATE-----
+MIICmDCCAYACCQDo0UEmHVSlqjANBgkqhkiG9w0BAQsFADANMQswCQYDVQQGEwJC
+RTAgFw0yMTEwMzAxODEwMDZaGA8yMTIxMTAwNjE4MTAwNlowDTELMAkGA1UEBhMC
+QkUwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCYjGqoyk9fKI/Hrl8R
+4E/7A3YzvsSnDhxyOT+k7YRTpuHwL7HF/9C5EFbGPgh0c8VsQxEzbPlAwPgajeHR
+K6zFpqbkA7wozktV/vIm8DZdc5h2flUpjScazAP/MXMp7i0CpR4qmsRl9HuhFmmd
+D9VxwWjgT4rafrOXhX8HjQ015FvjpFlFAzEiRAuxJzS0zd9OmDOyR4/VxBCHyf9D
+Wz4yfZdjaXXfbc5ljJiBGS4vR0inx2hPwcxD8YWHI+o9lSCjsr1OFy0bpjJ/aXih
+Na4pe19Np0IoI+s+mlx568+WqYXbFNovH71gUhhaUtZPWByzPaeHdK5SeylZArHl
+lkKPAgMBAAEwDQYJKoZIhvcNAQELBQADggEBAIIUHDzunkvnZ5DBMOKbEVn0fr2R
+yvKVNtRp59OWF1nJH9pr318TSk+yIClBRIismMHM6GnFYpDjqiGfJYtSN/amupGK
+h9b6aMDKKfSr7iAi9DzgPEvYaWcXGMRWmOWqxGS9zsvmM1vGkL7KsCWGIbtstxg+
+P8m4HSO6zXuBpe68yRSnNgrusMr1jviDE+aiyZANiZm7TPfIr7NHHmTk82aZtYCH
+yuDujnE5cNhJHH9iBGOBm51TZDMg9lFm9ItEAfHTC5++KfXMYokg7fqCJFU6d2y8
+O2P7e16PvX6lWcwTENq9ENiyEuTch3r+ZemJpoudKeaBcdrvLHSm+Nkvgwg=
+-----END CERTIFICATE-----

test/assets/TestCA.pem

@@ -0,0 +1,19 @@
+-----BEGIN CERTIFICATE-----
+MIIDDDCCAfSgAwIBAgIJALzCVuuVEADhMA0GCSqGSIb3DQEBCwUAMA0xCzAJBgNV
+BAYTAkJFMCAXDTIxMTAzMDE4MTExNVoYDzIxMjExMDA2MTgxMTE1WjAhMQswCQYD
+VQQGEwJCRTESMBAGA1UEAwwJbG9jYWxob3N0MIIBIjANBgkqhkiG9w0BAQEFAAOC
+AQ8AMIIBCgKCAQEAroS25VMhjk1IvVv3gvB4ZMPhwRpeDP/gfdd2mWaqPS9m/S36
+9DXGXKBiuNN0GNR8Ng1voaowFPRpvJAR6JBAhpdJsV+rLONg2jqUR49ihDZwpl77
+bvYG91DXcWGRAPLjEIHZQFtvZjQxTRGo3c614GyLzO4bz1Cac0TLtSwmlgOzWcg7
+g45+uvZOT7bJ7/7ryjUGassKiwE39RIRlFrE6DBj8TPTBmBSA6fzA2mlDX1YQzEz
+cZw7aM7IyTKEKM5C5Cc2H3ykd+fejPi/zM4ntrAOyeDXOwfskU5eXg8p/tL8USBn
+pDA94i1CNXBI+FDLwD2NZMVTb3J9vzghaN/5XwIDAQABo1kwVzAnBgNVHSMEIDAe
+oRGkDzANMQswCQYDVQQGEwJCRYIJAOjRQSYdVKWqMAkGA1UdEwQCMAAwCwYDVR0P
+BAQDAgTwMBQGA1UdEQQNMAuCCWxvY2FsaG9zdDANBgkqhkiG9w0BAQsFAAOCAQEA
+PvKbSVKzOBxl5MRczuo/QULzFLu6Rwe7dxVbTH4mOvcf2Njd5rL6oKZNAbPp5TBa
+HSXXIVJsB0cKVBMtovu+Q343AeMxPHclCOTXnKfTG3OplLuhtkzsjDMrjzynLnUK
+8iLdBT44Sa4BEPJwguZMb3fvhUKtbCj3WhoIodOgyD3W+Ufyvn5C9be6G9feBWrJ
+52O1HPp72oi54gng0VhqzUXhN6FfFSwFygxf22C1m1grl4CBdfYb6DV17JqINtk8
+HK0QOiWXlmUaGHOEYz8FZPOliUPpJWeD0N/tCAbkAYbMPvog93E1yNJjW4SYAh7z
+kVhFAcus9F4V9K47vx4a5w==
+-----END CERTIFICATE-----