storage: config: engine: Introduce dead letter queue #11000

cosmo0920 · 2025-10-08T11:29:09Z

This is because the current Fluent Bit mechanism does not offer for preserving invalid chunks for requesting via network.
So, if users encounter such behavior, the chunks will be just deleted and there is no clues to solve it.

Related to #9363.

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

Example configuration file for the change

For example, this feature will be enabled with:

service:
    storage.path:          /var/fluent-bit/storage
    storage.type:          filesystem
    storage.inherit:       On              # apply FS storage to inputs unless they override

    # Dead-letter queue (DLQ)
    storage.keep.rejected: true            # enable best-effort DLQ copies
    storage.rejected.path: rejected        # subdirectory/stream under storage.path

Debug log output from testing the change

Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Run local packaging test showing all targets (including any new ones) build.
Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

Documentation required for this feature

fluent/fluent-bit-docs#2166

Backporting

Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

New Features
- Dead‑Letter Queue (DLQ) support to quarantine non-retriable output records to filesystem-backed storage for later inspection.
- Runtime options to enable keeping rejected records and to configure the DLQ destination path.
- DLQ quarantine is invoked on non-retriable or failed-retry output paths.
Tests
- Unit tests verifying DLQ write/read flows, payload integrity, and chunk state preservation/restoration, plus DLQ-disabled behavior.

coderabbitai · 2025-10-08T11:29:45Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Adds filesystem-backed Dead-Letter Queue (DLQ) support: new config fields and keys, storage API to quarantine rejected chunks, engine calls to invoke quarantine on specific output failure paths, filesystem implementation to write DLQ files, and unit tests covering DLQ scenarios.

Changes

Cohort / File(s)	Summary
Config: header & fields `include/fluent-bit/flb_config.h`	Add `storage_keep_rejected` (int/bool), `storage_rejected_path` (char ), and `storage_rejected_stream` (void ) to `struct flb_config`; expose new DLQ-related config state.
Config: registration & lifecycle `src/flb_config.c`	Register `FLB_CONF_STORAGE_KEEP_REJECTED` and `FLB_CONF_STORAGE_REJECTED_PATH` service keys; initialize `storage_rejected_path = NULL`; free `storage_rejected_path` on shutdown; add `storage_keep_rejected` field handling.
Storage public API `include/fluent-bit/flb_storage.h`	Add forward declaration `struct flb_input_instance`; add prototypes: `flb_storage_create`, `flb_storage_input_create`, and `flb_storage_quarantine_chunk(...)` (DLQ API).
Storage implementation (DLQ) `src/flb_storage.c`	Add sanitization helper, FS-guarded get-or-create rejected stream, chunk-state restore helper, and public `flb_storage_quarantine_chunk` to copy a CIO chunk into filesystem-backed rejected stream (sanitization, unique naming, write/fsync/close, error handling). Returns -1 when FS backend unavailable.
Engine integration `src/flb_engine.c`	Add `handle_dlq_if_available(...)` helper and call it from `handle_output_event` on output failure paths (no-retry/drop, retry create/schedule failures, general error) to attempt quarantining rejected chunks before existing retry/metric handling.
Tests: build `tests/internal/CMakeLists.txt`	Add `tests/internal/storage_dlq.c` to unit test sources.
Tests: DLQ scenarios `tests/internal/storage_dlq.c`	New unit tests exercising filesystem-backed DLQ: create/write source chunks, call quarantine, locate latest `.flb` DLQ file, validate payload; tests cover enabled/disabled DLQ and chunk-state preservation/restoration; platform-aware discovery and cleanup utilities added.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Engine as Engine (handle_output_event)
  participant Task as Output Task / retry logic
  participant StorageAPI as flb_storage_quarantine_chunk
  participant CIO as CIO (source chunk)
  participant Rej as Rejected Stream (DLQ FS)

  rect rgb(245,250,255)
  note over Engine,Task: Output failure detected (drop / retry create/schedule fail / error)
  Engine->>Task: identify rejected chunk & input instance
  alt DLQ enabled & FS backend available & chunk available
    Engine->>StorageAPI: quarantine_chunk(ctx, ch, tag, status, out_name)
    StorageAPI->>CIO: bring chunk up if needed / read content
    StorageAPI->>Rej: get_or_create_rejected_stream()
    StorageAPI->>Rej: open DLQ chunk (sanitized name), write, fsync, close
    StorageAPI-->>Engine: return success / failure
  else DLQ disabled or FS unavailable
    Engine-->>Engine: skip quarantine (no-op)
  end
  end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Potential hotspots to review:

src/flb_storage.c — stream creation, filename sanitization, unique naming, write/fsync/close and state-restore correctness and error paths.
src/flb_engine.c — ensure DLQ calls are side-effect-safe and do not alter existing retry/metric semantics.
include/fluent-bit/flb_config.h / src/flb_config.c — config registration and lifecycle for new fields.
tests/internal/storage_dlq.c — platform-specific discovery/cleanup and test flakiness on CI.

Poem

I’m a rabbit with a patchwork pail,
I catch the logs that take a fail,
I sanitize names, tuck bytes inside,
A tiny DLQ where rejected bits hide,
Hopping home with a grateful tail. 🐇📦

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: introducing a dead letter queue mechanism across storage, config, and engine components.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch cosmo0920-introduce-dead-letter-queue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

tests/internal/storage_dlq.c

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (3)

src/flb_storage.c (1)
750-785: Guard rejected-stream lazy creation against races; consider pre-creating at init

This function lazily creates and caches ctx->storage_rejected_stream with no synchronization. Concurrent calls (from multiple output workers) can race, leading to duplicate create attempts or a torn write to the cached pointer.

Prefer pre-creating the rejected stream during flb_storage_create when storage_keep_rejected is enabled.

If you keep lazy creation, add a lock or other synchronization around get/create/cache.

Also, sanitize the configured name: storage_rejected_path may contain path separators; pass a single safe stream name to ChunkIO.

If ChunkIO stream creation is guaranteed to be thread-safe and idempotent, please confirm; otherwise, adopt one of the above.

Example minimal sanitization within this function:
-    struct cio_stream *st;
-    const char *name;
+    struct cio_stream *st;
+    const char *raw;
+    char name[256];
+    size_t i;
@@
-    name = ctx->storage_rejected_path ? ctx->storage_rejected_path : "rejected";
+    raw = ctx->storage_rejected_path ? ctx->storage_rejected_path : "rejected";
+    snprintf(name, sizeof(name), "%s", raw);
+    name[sizeof(name) - 1] = '\0';
+    for (i = 0; name[i] != '\0'; i++) {
+        if (name[i] == '/' || name[i] == '\\') {
+            name[i] = '_';
+        }
+    }
tests/internal/storage_dlq.c (2)
262-274: Use join_path for portability (Windows path separators)

Hardcoding "/" may fail on Windows. Reuse join_path.
-    snprintf(path, sizeof(path), "%s/%s", root, stream_name);
-    path[sizeof(path)-1] = '\0';
+    join_path(path, sizeof(path), root, stream_name);
458-463: Avoid non-portable basename; implement a portable helper

basename() isn’t available on Windows and requires libgen.h on Unix. Use a small portable helper.

Apply this helper near other utilities:
+static const char *base_name_portable(const char *p)
+{
+    const char *s1 = strrchr(p, '/');
+#ifdef _WIN32
+    const char *s2 = strrchr(p, '\\');
+    const char *b = (s1 && s2) ? (s1 > s2 ? s1 : s2) : (s1 ? s1 : s2);
+#else
+    const char *b = s1;
+#endif
+    return b ? b + 1 : p;
+}
Then replace usage:
-    /* get just the filename (basename) */
-    strncpy(latest_copy, latest, sizeof(latest_copy)-1);
-    latest_copy[sizeof(latest_copy)-1] = '\0';
-    base = basename(latest_copy);
+    /* get just the filename (basename) */
+    base = base_name_portable(latest);
And remove the now-unused latest_copy declaration:
-    char latest_copy[1024];

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 912b7d7 and 4530987.

📒 Files selected for processing (7)

include/fluent-bit/flb_config.h (2 hunks)
include/fluent-bit/flb_storage.h (2 hunks)
src/flb_config.c (3 hunks)
src/flb_engine.c (5 hunks)
src/flb_storage.c (1 hunks)
tests/internal/CMakeLists.txt (1 hunks)
tests/internal/storage_dlq.c (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (5)

src/flb_storage.c (1)

include/fluent-bit/flb_mem.h (1)

flb_free (126-128)

include/fluent-bit/flb_storage.h (1)

src/flb_storage.c (1)

flb_storage_quarantine_chunk (787-859)

src/flb_engine.c (5)

src/flb_input_chunk.c (1)

flb_input_chunk_get_tag (2174-2200)

src/flb_sds.c (2)

flb_sds_create_len (58-76)

flb_sds_destroy (389-399)

src/flb_input.c (1)

flb_input_name (790-797)

src/flb_output.c (1)

flb_output_name (1087-1094)

src/flb_storage.c (1)

flb_storage_quarantine_chunk (787-859)

src/flb_config.c (1)

include/fluent-bit/flb_mem.h (1)

flb_free (126-128)

tests/internal/storage_dlq.c (2)

src/flb_config.c (2)

flb_config_exit (448-628)

flb_config_init (232-446)

src/flb_storage.c (1)

flb_storage_quarantine_chunk (787-859)

🔇 Additional comments (2)

src/flb_engine.c (1)

234-276: Solid defensive gating on DLQ handling.

Short-circuiting when DLQ is disabled or the task lacks a chunk keeps us off the hot path unless quarantine is actually configured, which is exactly what we need here.

tests/internal/storage_dlq.c (1)

386-397: Confirm cio_qsort comparator usage

Passing NULL as comparator assumes ChunkIO provides a sensible default. If not guaranteed, pass a comparator or drop the call.

src/flb_storage.c

tests/internal/storage_dlq.c

Signed-off-by: Hiroshi Hatake <[email protected]>

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7a599b and 1f91cf5.

📒 Files selected for processing (1)

src/flb_engine.c (5 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/flb_engine.c (5)

src/flb_input_chunk.c (1)

flb_input_chunk_get_tag (3236-3253)

src/flb_sds.c (2)

flb_sds_create_len (58-76)

flb_sds_destroy (389-399)

src/flb_input.c (1)

flb_input_name (790-797)

src/flb_output.c (1)

flb_output_name (1099-1106)

src/flb_storage.c (1)

flb_storage_quarantine_chunk (846-923)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (31)

GitHub Check: pr-windows-build / call-build-windows-package (Windows 64bit (Arm64), amd64_arm64, -DCMAKE_SYSTEM_NAME=Windows -DCMA...
GitHub Check: pr-windows-build / call-build-windows-package (Windows 64bit, x64, x64-windows-static, 3.31.6)
GitHub Check: pr-windows-build / call-build-windows-package (Windows 32bit, x86, x86-windows-static, 3.31.6)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SANITIZE_MEMORY=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SIMD=Off, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_COMPILER_STRICT_POINTER_TYPES=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DSANITIZE_ADDRESS=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SIMD=Off, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_COVERAGE=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SANITIZE_THREAD=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_ARROW=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SANITIZE_MEMORY=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SIMD=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SANITIZE_THREAD=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DSANITIZE_UNDEFINED=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SIMD=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SMALL=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DSANITIZE_ADDRESS=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_JEMALLOC=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DSANITIZE_UNDEFINED=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_JEMALLOC=Off, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SMALL=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_JEMALLOC=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_JEMALLOC=Off, 3.31.6, gcc, g++)
GitHub Check: PR - fuzzing test
GitHub Check: pr-compile-system-libs (-DFLB_PREFER_SYSTEM_LIBS=On, 3.31.6, gcc, g++, ubuntu-24.04, clang-14)
GitHub Check: pr-compile-system-libs (-DFLB_PREFER_SYSTEM_LIBS=On, 3.31.6, gcc, g++, ubuntu-22.04, clang-12)
GitHub Check: pr-compile-without-cxx (3.31.6)
GitHub Check: pr-compile-system-libs (-DFLB_PREFER_SYSTEM_LIBS=On, 3.31.6, clang, clang++, ubuntu-22.04, clang-12)
GitHub Check: pr-compile-system-libs (-DFLB_PREFER_SYSTEM_LIBS=On, 3.31.6, clang, clang++, ubuntu-24.04, clang-14)
GitHub Check: pr-compile-centos-7

src/flb_engine.c

Signed-off-by: Hiroshi Hatake <[email protected]>

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/flb_engine.c (2)
257-259: Redundant null check for ic.

At line 257, the check !ic is redundant because line 251 already validates !task->ic and returns early if null. Since ic is assigned directly from task->ic at line 255, it cannot be null at line 257. The check for !ic->chunk is necessary and should be kept.

Apply this diff to remove the redundant check:
-    if (!ic || !ic->chunk) {
+    if (!ic->chunk) {
         return;
     }
416-416: Consider passing meaningful status codes to DLQ.

All four call sites pass status_code = 0 to handle_dlq_if_available, which loses diagnostic context. Consider passing distinct codes to help operators differentiate rejection reasons:

Line 416: No retry configured

Line 464: Retry creation failed

Line 518: Retry scheduling failed

Line 556: General output error

This would enhance DLQ analysis and troubleshooting.

Also applies to: 464-464, 518-518, 556-556

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f91cf5 and 90acba1.

📒 Files selected for processing (1)

src/flb_engine.c (5 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/flb_engine.c (5)

src/flb_input_chunk.c (1)

flb_input_chunk_get_tag (3236-3253)

src/flb_sds.c (2)

flb_sds_create_len (58-76)

flb_sds_destroy (389-399)

src/flb_input.c (1)

flb_input_name (790-797)

src/flb_output.c (1)

flb_output_name (1099-1106)

src/flb_storage.c (1)

flb_storage_quarantine_chunk (846-923)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (28)

GitHub Check: run-ubuntu-unit-tests (-DFLB_SANITIZE_MEMORY=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SANITIZE_THREAD=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_COMPILER_STRICT_POINTER_TYPES=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_ARROW=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SIMD=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SANITIZE_THREAD=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SANITIZE_MEMORY=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SIMD=Off, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SIMD=Off, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SIMD=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_COVERAGE=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DSANITIZE_UNDEFINED=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DSANITIZE_ADDRESS=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DSANITIZE_ADDRESS=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DSANITIZE_UNDEFINED=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_JEMALLOC=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_JEMALLOC=Off, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SMALL=On, 3.31.6, gcc, g++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_SMALL=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_JEMALLOC=On, 3.31.6, clang, clang++)
GitHub Check: run-ubuntu-unit-tests (-DFLB_JEMALLOC=Off, 3.31.6, clang, clang++)
GitHub Check: pr-compile-system-libs (-DFLB_PREFER_SYSTEM_LIBS=On, 3.31.6, clang, clang++, ubuntu-22.04, clang-12)
GitHub Check: pr-compile-system-libs (-DFLB_PREFER_SYSTEM_LIBS=On, 3.31.6, clang, clang++, ubuntu-24.04, clang-14)
GitHub Check: pr-compile-system-libs (-DFLB_PREFER_SYSTEM_LIBS=On, 3.31.6, gcc, g++, ubuntu-24.04, clang-14)
GitHub Check: pr-compile-centos-7
GitHub Check: pr-compile-system-libs (-DFLB_PREFER_SYSTEM_LIBS=On, 3.31.6, gcc, g++, ubuntu-22.04, clang-12)
GitHub Check: pr-compile-without-cxx (3.31.6)
GitHub Check: PR - fuzzing test

🔇 Additional comments (1)

src/flb_engine.c (1)

235-280: Overall implementation looks solid; past critical issue resolved.

The logic at line 262 correctly calls flb_input_chunk_get_tag first and then validates the outputs, addressing the critical issue flagged in past reviews. The function properly handles resource cleanup and provides appropriate fallbacks.

github-actions bot added the docs-required label Oct 8, 2025

cosmo0920 temporarily deployed to pr October 8, 2025 11:29 — with GitHub Actions Inactive

cosmo0920 temporarily deployed to pr October 8, 2025 11:49 — with GitHub Actions Inactive

cosmo0920 had a problem deploying to pr October 8, 2025 11:49 — with GitHub Actions Failure

cosmo0920 temporarily deployed to pr October 9, 2025 08:17 — with GitHub Actions Inactive

cosmo0920 force-pushed the cosmo0920-introduce-dead-letter-queue branch from e91922d to 4530987 Compare October 9, 2025 08:30

cosmo0920 temporarily deployed to pr October 9, 2025 08:30 — with GitHub Actions Inactive

cosmo0920 temporarily deployed to pr October 9, 2025 08:50 — with GitHub Actions Inactive

cosmo0920 marked this pull request as ready for review October 9, 2025 10:58

cosmo0920 requested review from edsiper, fujimotos and koleini as code owners October 9, 2025 10:59

chatgpt-codex-connector bot reviewed Oct 9, 2025

View reviewed changes

tests/internal/storage_dlq.c Show resolved Hide resolved

coderabbitai bot reviewed Oct 9, 2025

View reviewed changes

src/flb_storage.c Show resolved Hide resolved

tests/internal/storage_dlq.c Show resolved Hide resolved

cosmo0920 temporarily deployed to pr October 9, 2025 11:49 — with GitHub Actions Inactive

cosmo0920 force-pushed the cosmo0920-introduce-dead-letter-queue branch from 8874e0d to de96d72 Compare October 9, 2025 11:50

storage: internal: tests: Confirm the initial state of chunks

e7a599b

Signed-off-by: Hiroshi Hatake <[email protected]>

cosmo0920 force-pushed the cosmo0920-introduce-dead-letter-queue branch from caca209 to e7a599b Compare November 10, 2025 03:35

cosmo0920 temporarily deployed to pr November 10, 2025 03:35 — with GitHub Actions Inactive

cosmo0920 temporarily deployed to pr November 10, 2025 03:54 — with GitHub Actions Inactive

cosmo0920 had a problem deploying to pr November 10, 2025 04:13 — with GitHub Actions Failure

coderabbitai bot reviewed Nov 10, 2025

View reviewed changes

src/flb_engine.c Outdated Show resolved Hide resolved

engine: Tweak conditions for enabling DLQ

90acba1

Signed-off-by: Hiroshi Hatake <[email protected]>

cosmo0920 force-pushed the cosmo0920-introduce-dead-letter-queue branch from 1f91cf5 to 90acba1 Compare November 10, 2025 04:30

cosmo0920 had a problem deploying to pr November 10, 2025 04:30 — with GitHub Actions Failure

coderabbitai bot reviewed Nov 10, 2025

View reviewed changes

cosmo0920 temporarily deployed to pr November 10, 2025 12:07 — with GitHub Actions Inactive

cosmo0920 temporarily deployed to pr November 10, 2025 12:27 — with GitHub Actions Inactive

cosmo0920 mentioned this pull request Nov 10, 2025

storage: Add descriptions for DLQ parameters fluent/fluent-bit-docs#2166

Merged

edsiper merged commit 29f41f6 into master Nov 10, 2025
89 of 93 checks passed

edsiper deleted the cosmo0920-introduce-dead-letter-queue branch November 10, 2025 16:19

BrewTestBot mentioned this pull request Nov 12, 2025

fluent-bit 4.2.0 Homebrew/homebrew-core#254082

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

storage: config: engine: Introduce dead letter queue #11000

storage: config: engine: Introduce dead letter queue #11000

cosmo0920 commented Oct 8, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 8, 2025 •

edited

Loading

Other AI code review bot(s) detected

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

storage: config: engine: Introduce dead letter queue #11000

storage: config: engine: Introduce dead letter queue #11000

Conversation

cosmo0920 commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cosmo0920 commented Oct 8, 2025 •

edited

Loading

coderabbitai bot commented Oct 8, 2025 •

edited

Loading