-
Notifications
You must be signed in to change notification settings - Fork 12
Closed
Description
You need to replace a line in flint-bot/sparky/blob/master/lib/res/webhooks.js
offending line:
...
if(sig === hmac.digest('hex')) {
...
Solution: replace triple equals with time-constant comparison from crypto lib
nodejs/node#3073
vulnerability explanation:
https://en.wikipedia.org/wiki/Timing_attack
discussion (in depth explanation):
nodejs/node-v0.x-archive#8560
Thank you for building this framework.
Steven Miller
Cisco Systems, IT Engineer
Metadata
Metadata
Assignees
Labels
No labels