Skip to content

Commit fffed57

Browse files
committed
fix last jupyterlab tests
1 parent 990c0ef commit fffed57

File tree

2 files changed

+21
-9
lines changed

2 files changed

+21
-9
lines changed

packages/perspective-jupyterlab/test/jupyter/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ const describe_jupyter = (body, { name, root } = {}) => {
9090
* @param {*} cells
9191
* @param {*} body
9292
*/
93-
const test_jupyter = (name, cells, body, args = {}) => {
93+
const test_jupyter = (name, cells, body) => {
9494
const notebook_name = `${name.replace(/[ \.']/g, "_")}.ipynb`;
9595
generate_notebook(notebook_name, cells);
9696
const url = `doc/tree/${notebook_name}`;

packages/perspective-jupyterlab/test/jupyter/widget.spec.js

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,20 +41,23 @@ describe_jupyter(
4141
async ({ page }) => {
4242
const viewer = await default_body(page);
4343
const num_columns = await viewer.evaluate(async (viewer) => {
44-
const tbl = viewer.querySelector("regular-table");
44+
const tbl = viewer
45+
.querySelector("perspective-viewer-datagrid")
46+
.shadowRoot.querySelector("regular-table");
4547
return tbl.querySelector("thead tr").childElementCount;
4648
});
4749

4850
expect(num_columns).toEqual(3);
4951

5052
const num_rows = await viewer.evaluate(async (viewer) => {
51-
const tbl = viewer.querySelector("regular-table");
53+
const tbl = viewer
54+
.querySelector("perspective-viewer-datagrid")
55+
.shadowRoot.querySelector("regular-table");
5256
return tbl.querySelectorAll("tbody tr").length;
5357
});
5458

5559
expect(num_rows).toEqual(5);
56-
},
57-
{ timeout: 120000 }
60+
}
5861
);
5962

6063
test_jupyter(
@@ -70,14 +73,18 @@ describe_jupyter(
7073
async ({ page }) => {
7174
const viewer = await default_body(page);
7275
const num_columns = await viewer.evaluate(async (viewer) => {
73-
const tbl = viewer.querySelector("regular-table");
76+
const tbl = viewer
77+
.querySelector("perspective-viewer-datagrid")
78+
.shadowRoot.querySelector("regular-table");
7479
return tbl.querySelector("thead tr").childElementCount;
7580
});
7681

7782
expect(num_columns).toEqual(3);
7883

7984
const num_rows = await viewer.evaluate(async (viewer) => {
80-
const tbl = viewer.querySelector("regular-table");
85+
const tbl = viewer
86+
.querySelector("perspective-viewer-datagrid")
87+
.shadowRoot.querySelector("regular-table");
8188
return tbl.querySelectorAll("tbody tr").length;
8289
});
8390

@@ -96,14 +103,19 @@ describe_jupyter(
96103
async ({ page }) => {
97104
const viewer = await default_body(page);
98105
const num_columns = await viewer.evaluate(async (viewer) => {
99-
const tbl = viewer.querySelector("regular-table");
106+
const tbl = viewer
107+
.querySelector("perspective-viewer-datagrid")
108+
.shadowRoot.querySelector("regular-table");
109+
100110
return tbl.querySelector("thead tr").childElementCount;
101111
});
102112

103113
expect(num_columns).toEqual(3);
104114

105115
const num_rows = await viewer.evaluate(async (viewer) => {
106-
const tbl = viewer.querySelector("regular-table");
116+
const tbl = viewer
117+
.querySelector("perspective-viewer-datagrid")
118+
.shadowRoot.querySelector("regular-table");
107119
return tbl.querySelectorAll("tbody tr").length;
108120
});
109121

0 commit comments

Comments
 (0)