Skip to content

Commit eedb934

Browse files
authored
Merge pull request #2595 from finos/tkp/dco
Update contributing documentation for DCO
2 parents ba0539c + 1f0491f commit eedb934

File tree

1 file changed

+17
-24
lines changed

1 file changed

+17
-24
lines changed

CONTRIBUTING.md

Lines changed: 17 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,8 @@ we may remove or reclassify comments or Issues which violate the guidelines.
3030
When submitting Pull Request (PR), please respect the following coding
3131
guidelines:
3232

33-
- Complete your
34-
[FINOS CLA](https://finosfoundation.atlassian.net/wiki/spaces/FINOS/pages/75530375/Contribution+Compliance+Requirements#ContributionComplianceRequirements-ContributorLicenseAgreement)
35-
_before_ opening a PR.
33+
- Sign commits (e.g. with `-s`) in accordance with the DCO policy detailed
34+
below, _before_ opening a PR.
3635
- Please make sure PRs include:
3736

3837
- Tests asserting behavior of any new or modified features.
@@ -47,29 +46,23 @@ guidelines:
4746
- Try to organize commits as functional components (as opposed to
4847
timeline-of-development).
4948

50-
## CLA
49+
Please note that non substantive changes, large changes without prior
50+
discussion, etc, are not accepted and pull requests may be closed.
5151

52-
Note that commits and pull requests to FINOS repositories such as Perspective
53-
may only be accepted from those contributors with a
54-
[Contributor License Agreement (CLA)](https://finosfoundation.atlassian.net/wiki/spaces/FINOS/pages/75530375/Contribution+Compliance+Requirements#ContributionComplianceRequirements-ContributorLicenseAgreement)
55-
with FINOS. This may take the form of either:
52+
## DCO
5653

57-
- an active, executed Individual Contributor License Agreement (ICLA) with
58-
FINOS, OR
59-
- coverage under an existing, active Corporate Contribution License Agreement
60-
(CCLA) executed with FINOS (most likely by the developer's employer). Please
61-
note that some, though not all, CCLAs require individuals/employees to be
62-
explicitly named on the CCLA.
54+
The Perspective project requires contributors to affirm their contributions via
55+
a [Developer Certificate of Origin](https://developercertificate.org), which
56+
certifies that developers are authorized to make their contribution, either on
57+
their own behalf or on behalf of their employer.
6358

64-
Commits from individuals not covered under an CLA can not be merged by
65-
Perspective's committers. We encourage you to check that you have a CLA in place
66-
well in advance of making your first pull request.
67-
68-
Need an ICLA? Unsure if you are covered under an existing CCLA? Confused? Email
69-
[[email protected]](mailto:[email protected]) and the foundation team will help get it
70-
sorted out for you.
59+
In practice, this means that all commits to Perspective must be signed (e.g.
60+
with `-s`/`-S`). Pull requests with any unsigned commits, or where the signer
61+
does not match the commit author, can not be merged by Perspective's committers.
62+
We ask that you check that you have a signed all your commits before making a
63+
pull request. A [DCO enforcement bot](https://github.com/apps/dco) will
64+
automatically scan and flag any pull requests that lack a valid sign-off.
7165

7266
If you have any general questions about contributing to Perspective, please feel
73-
free to open an issue on
74-
[github](https://github.com/finos/perspective/issues/new), or email
75-
[[email protected]](mailto:finos.org).
67+
free to open an discussion on
68+
[github](https://github.com/finos/perspective/discussions)

0 commit comments

Comments
 (0)