Fix emscripten sloppy typescript

Signed-off-by: Andrew Stein <[email protected]>

Author: texodus

packages/perspective-jupyterlab/build.mjs

@@ -112,7 +112,7 @@ function add(builder, path, path2) {
     );
 }
 
-const IS_TEST = process.argv.some((x) => x == "--test");
+const IS_TEST = process.argv.some((x) => x === "--test");
 const BUILD = IS_TEST
     ? [LAB_BUILD, ...NB_BUILDS, TEST_BUILD]
     : [LAB_BUILD, ...NB_BUILDS];

tools/perspective-scripts/emsdk.patch

@@ -0,0 +1,13 @@
+diff --git a/upstream/emscripten/tools/emscripten.py b/upstream/emscripten/tools/emscripten.py
+index f73e2e1..9129d4f 100644
+--- a/upstream/emscripten/tools/emscripten.py
++++ b/upstream/emscripten/tools/emscripten.py
+@@ -627,7 +627,7 @@ def create_tsd_exported_runtime_methods(metadata):
+     tsc = ['tsc']
+   else:
+     tsc = shared.get_npm_cmd('tsc')
+-  cmd = tsc + ['--outFile', tsc_output_file, '--declaration', '--emitDeclarationOnly', '--allowJs', js_doc_file]
++  cmd = tsc + ['--outFile', tsc_output_file, '--declaration', '--skipLibCheck', '--emitDeclarationOnly', '--allowJs', js_doc_file]
+   shared.check_call(cmd, cwd=path_from_root())
+   return utils.read_file(tsc_output_file)
+ 

tools/perspective-scripts/install_emsdk.mjs

@@ -17,6 +17,8 @@ import * as dotenv from "dotenv";
 import sh from "./sh.mjs";
 import { getWorkspaceRoot, getWorkspacePackageJson } from "./workspace.mjs";
 
+import "zx/globals";
+
 const pkg = getWorkspacePackageJson();
 
 const emscripten = pkg.emscripten;
@@ -66,4 +68,5 @@ if (!process.env.PSP_SKIP_EMSDK_INSTALL) {
     }
 
     toolchain_install();
+    $.sync`cd .emsdk && git apply ../tools/perspective-scripts/emsdk.patch`;
 }

tools/perspective-scripts/test_js.mjs

@@ -13,11 +13,11 @@
 import sh from "./sh.mjs";
 import { getarg, run_with_scope, get_scope } from "./sh_perspective.mjs";
 
+const IS_NEEDS_BUILD = get_scope().some((x) => x === "perspective-jupyterlab");
+
 // Unfortunately we have to handle parts of the Jupyter test case here,
 // as the Jupyter server needs to be run outside of the main Jest process.
-const IS_JUPYTER =
-    !!getarg("--jupyter") &&
-    process.env.PACKAGE.indexOf("perspective-jupyterlab") > -1;
+const IS_JUPYTER = !!getarg("--jupyter") && IS_NEEDS_BUILD;
 
 if (getarg("--debug")) {
     console.log("-- Running tests in debug mode.");
@@ -88,10 +88,13 @@ if (!IS_JUPYTER) {
 }
 
 if (process.env.PACKAGE) {
+    if (IS_NEEDS_BUILD) {
+        await run_with_scope`test:jupyter:build`;
+    }
+
     if (IS_JUPYTER) {
         // Jupyterlab is guaranteed to have started at this point, so
         // copy the test files over and run the tests.
-        await run_with_scope`test:jupyter:build`;
         playwright("perspective-jupyterlab", true).runSync();
         process.exit(0);
     }