Skip to content

Commit 2f17e9b

Browse files
authored
CLI fire prep updates (ultralytics#7229)
* CLI fire prep updates * revert unintentional TF export change
1 parent 6f6285e commit 2f17e9b

File tree

8 files changed

+19
-10
lines changed

8 files changed

+19
-10
lines changed

detect.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ def parse_opt():
238238
parser.add_argument('--dnn', action='store_true', help='use OpenCV DNN for ONNX inference')
239239
opt = parser.parse_args()
240240
opt.imgsz *= 2 if len(opt.imgsz) == 1 else 1 # expand
241-
print_args(FILE.stem, opt)
241+
print_args(vars(opt))
242242
return opt
243243

244244

export.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ def parse_opt():
566566
default=['torchscript', 'onnx'],
567567
help='torchscript, onnx, openvino, engine, coreml, saved_model, pb, tflite, edgetpu, tfjs')
568568
opt = parser.parse_args()
569-
print_args(FILE.stem, opt)
569+
print_args(vars(opt))
570570
return opt
571571

572572

models/tf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,7 @@ def parse_opt():
480480
parser.add_argument('--dynamic', action='store_true', help='dynamic batch size')
481481
opt = parser.parse_args()
482482
opt.imgsz *= 2 if len(opt.imgsz) == 1 else 1 # expand
483-
print_args(FILE.stem, opt)
483+
print_args(vars(opt))
484484
return opt
485485

486486

models/yolo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ def parse_model(d, ch): # model_dict, input_channels(3)
308308
parser.add_argument('--test', action='store_true', help='test all yolo*.yaml')
309309
opt = parser.parse_args()
310310
opt.cfg = check_yaml(opt.cfg) # check YAML
311-
print_args(FILE.stem, opt)
311+
print_args(vars(opt))
312312
device = select_device(opt.device)
313313

314314
# Create model

train.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -515,7 +515,7 @@ def parse_opt(known=False):
515515
def main(opt, callbacks=Callbacks()):
516516
# Checks
517517
if RANK in [-1, 0]:
518-
print_args(FILE.stem, opt)
518+
print_args(vars(opt))
519519
check_git_status()
520520
check_requirements(exclude=['thop'])
521521

utils/benchmarks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def parse_opt():
9292
parser.add_argument('--device', default='', help='cuda device, i.e. 0 or 0,1,2,3 or cpu')
9393
parser.add_argument('--half', action='store_true', help='use FP16 half-precision inference')
9494
opt = parser.parse_args()
95-
print_args(FILE.stem, opt)
95+
print_args(vars(opt))
9696
return opt
9797

9898

utils/general.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import contextlib
77
import glob
8+
import inspect
89
import logging
910
import math
1011
import os
@@ -20,6 +21,7 @@
2021
from multiprocessing.pool import ThreadPool
2122
from pathlib import Path
2223
from subprocess import check_output
24+
from typing import Optional
2325
from zipfile import ZipFile
2426

2527
import cv2
@@ -163,9 +165,15 @@ def methods(instance):
163165
return [f for f in dir(instance) if callable(getattr(instance, f)) and not f.startswith("__")]
164166

165167

166-
def print_args(name, opt):
167-
# Print argparser arguments
168-
LOGGER.info(colorstr(f'{name}: ') + ', '.join(f'{k}={v}' for k, v in vars(opt).items()))
168+
def print_args(args: Optional[dict] = None, show_file=True, show_fcn=False):
169+
# Print function arguments (optional args dict)
170+
x = inspect.currentframe().f_back # previous frame
171+
file, _, fcn, _, _ = inspect.getframeinfo(x)
172+
if args is None: # get args automatically
173+
args, _, _, frm = inspect.getargvalues(x)
174+
args = {k: v for k, v in frm.items() if k in args}
175+
s = (f'{Path(file).stem}: ' if show_file else '') + (f'{fcn}: ' if show_fcn else '')
176+
LOGGER.info(colorstr(s) + ', '.join(f'{k}={v}' for k, v in args.items()))
169177

170178

171179
def init_seeds(seed=0):
@@ -346,6 +354,7 @@ def check_img_size(imgsz, s=32, floor=0):
346354
if isinstance(imgsz, int): # integer i.e. img_size=640
347355
new_size = max(make_divisible(imgsz, int(s)), floor)
348356
else: # list i.e. img_size=[640, 480]
357+
imgsz = list(imgsz) # convert to list if tuple
349358
new_size = [max(make_divisible(x, int(s)), floor) for x in imgsz]
350359
if new_size != imgsz:
351360
LOGGER.warning(f'WARNING: --img-size {imgsz} must be multiple of max stride {s}, updating to {new_size}')

val.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ def parse_opt():
350350
opt.data = check_yaml(opt.data) # check YAML
351351
opt.save_json |= opt.data.endswith('coco.yaml')
352352
opt.save_txt |= opt.save_hybrid
353-
print_args(FILE.stem, opt)
353+
print_args(vars(opt))
354354
return opt
355355

356356

0 commit comments

Comments
 (0)