Skip to content

Commit c960217

Browse files
committed
refactor(element-shade): rename selection event handler for better readability
1 parent 09fd9ca commit c960217

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

packages/element-shade/src/index.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ export default class CropperShade extends CropperElement {
2323

2424
static $version = '__VERSION__';
2525

26-
protected $onCanvasChange: EventListener | null = null;
27-
2826
protected $onCanvasActionEnd: EventListener | null = null;
2927

3028
protected $onCanvasActionStart: EventListener | null = null;
3129

30+
protected $onSelectionChange: EventListener | null = null;
31+
3232
protected $style = style;
3333

3434
x = 0;
@@ -84,7 +84,7 @@ export default class CropperShade extends CropperElement {
8484
this.hidden = true;
8585
}
8686
};
87-
this.$onCanvasChange = (event) => {
87+
this.$onSelectionChange = (event) => {
8888
const {
8989
x,
9090
y,
@@ -100,7 +100,7 @@ export default class CropperShade extends CropperElement {
100100
};
101101
on($canvas, EVENT_ACTION_START, this.$onCanvasActionStart);
102102
on($canvas, EVENT_ACTION_END, this.$onCanvasActionEnd);
103-
on($canvas, EVENT_CHANGE, this.$onCanvasChange);
103+
on($canvas, EVENT_CHANGE, this.$onSelectionChange);
104104
}
105105
}
106106

@@ -121,9 +121,9 @@ export default class CropperShade extends CropperElement {
121121
this.$onCanvasActionEnd = null;
122122
}
123123

124-
if (this.$onCanvasChange) {
125-
off($canvas, EVENT_CHANGE, this.$onCanvasChange);
126-
this.$onCanvasChange = null;
124+
if (this.$onSelectionChange) {
125+
off($canvas, EVENT_CHANGE, this.$onSelectionChange);
126+
this.$onSelectionChange = null;
127127
}
128128
}
129129

0 commit comments

Comments
 (0)