Make _name() work well with classes #23
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the implementation of .functionName in sinon as a reference https://github.com/sinonjs/sinon/blob/c8901e7bdfd95bc34daf509fa3cc56d3100fb206/docs/releases/sinon-1.10.1.js#L446
Collaborator
|
Why not steal the sinon implementation actually? |
Collaborator
|
(PS it seems i can both merge and publish to npm so it will be easy to release an improvement here) |
Collaborator
|
It appears that Travis tests on none of the Node versions work after we'd merge this, where previously 2 out of 5 worked. Would be best to first get passing tests and then merge any improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the implementation of .functionName in sinon as a reference https://github.com/sinonjs/sinon/blob/c8901e7bdfd95bc34daf509fa3cc56d3100fb206/docs/releases/sinon-1.10.1.js#L446