Skip to content

Commit d6b080d

Browse files
authored
fix: Fixed integration tests for qdrant and milvus (#5224)
1 parent 34c393c commit d6b080d

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

sdk/python/feast/feature_store.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2020,10 +2020,6 @@ def _retrieve_from_online_store(
20202020
"""
20212021
Search and return document features from the online document store.
20222022
"""
2023-
vector_field_metadata = _get_feature_view_vector_field_metadata(table)
2024-
if vector_field_metadata:
2025-
distance_metric = vector_field_metadata.vector_search_metric
2026-
20272023
documents = provider.retrieve_online_documents(
20282024
config=self.config,
20292025
table=table,

sdk/python/feast/infra/online_stores/qdrant_online_store/qdrant.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,11 @@ def online_write_batch(
115115
encoded_value = base64.b64encode(value.SerializeToString()).decode(
116116
"utf-8"
117117
)
118-
vector_val = json.loads(get_list_val_str(value))
118+
vector_val = get_list_val_str(value)
119+
if vector_val:
120+
vector = {config.online_store.vector_name: json.loads(vector_val)}
121+
else:
122+
vector = {}
119123
points.append(
120124
models.PointStruct(
121125
id=uuid.uuid4().hex,
@@ -126,7 +130,7 @@ def online_write_batch(
126130
"timestamp": timestamp,
127131
"created_ts": created_ts,
128132
},
129-
vector={config.online_store.vector_name: vector_val},
133+
vector=vector,
130134
)
131135
)
132136

sdk/python/tests/integration/feature_repos/repo_configuration.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -565,9 +565,13 @@ def construct_test_environment(
565565
cache_ttl_seconds=1,
566566
)
567567

568-
if isinstance(
569-
test_repo_config.online_store, dict
570-
) and test_repo_config.online_store.get("type") in ["milvus", "pgvector", "qdrant"]:
568+
online_store = (
569+
test_repo_config.online_store.get("type")
570+
if isinstance(test_repo_config.online_store, dict)
571+
else test_repo_config.online_store
572+
)
573+
574+
if online_store in ["milvus", "pgvector", "qdrant"]:
571575
entity_key_serialization_version = 3
572576

573577
environment_params = {

sdk/python/tests/integration/online_store/test_universal_online.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -870,7 +870,7 @@ def test_retrieve_online_documents(environment, fake_document_data):
870870
fs.write_to_online_store("item_embeddings", df)
871871

872872
documents = fs.retrieve_online_documents(
873-
features=["item_embeddings:embedding_float"],
873+
features=["item_embeddings:embedding_float", "item_embeddings:item_id"],
874874
query=[1.0, 2.0],
875875
top_k=2,
876876
distance_metric="L2",

0 commit comments

Comments
 (0)