Skip to content

Commit d202d51

Browse files
mickey-liuYun Nan Liu
andauthored
fix: Added additional value types to UI parser and removed references to registry-bq.json (#2361)
Signed-off-by: Yun Nan Liu <[email protected]> Co-authored-by: Yun Nan Liu <[email protected]>
1 parent 993616f commit d202d51

File tree

3 files changed

+6
-19
lines changed

3 files changed

+6
-19
lines changed

ui/src/components/ProjectSelector.test.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,12 @@ import App from "../App";
88
import {
99
projectsListWithDefaultProject,
1010
creditHistoryRegistry,
11-
bigQueryProjectRegistry,
1211
} from "../mocks/handlers";
1312

1413
// declare which API requests to mock
1514
const server = setupServer(
1615
projectsListWithDefaultProject,
17-
creditHistoryRegistry,
18-
bigQueryProjectRegistry
16+
creditHistoryRegistry
1917
);
2018

2119
// establish API mocking before all tests

ui/src/mocks/handlers.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { rest } from "msw";
22
import registry from "../../public/registry.json";
3-
import registry_bq from "../../public/registry_bq.json";
43

54
const projectsListWithDefaultProject = rest.get(
65
"/projects-list.json",
@@ -17,12 +16,6 @@ const projectsListWithDefaultProject = rest.get(
1716
id: "credit_score_project",
1817
registryPath: "/registry.json",
1918
},
20-
{
21-
name: "Big Query Project",
22-
xxxdescription: "Doing stuff in Google Big Query",
23-
id: "big_query_project",
24-
registryPath: "/registry_bq.json",
25-
},
2619
],
2720
})
2821
);
@@ -33,15 +26,7 @@ const creditHistoryRegistry = rest.get("/registry.json", (req, res, ctx) => {
3326
return res(ctx.status(200), ctx.json(registry));
3427
});
3528

36-
const bigQueryProjectRegistry = rest.get(
37-
"/registry_bq.json",
38-
(req, res, ctx) => {
39-
return res(ctx.status(200), ctx.json(registry_bq));
40-
}
41-
);
42-
4329
export {
4430
projectsListWithDefaultProject,
45-
creditHistoryRegistry,
46-
bigQueryProjectRegistry,
31+
creditHistoryRegistry
4732
};

ui/src/parsers/types.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ enum FEAST_FEATURE_VALUE_TYPES {
1010
INT64 = "INT64",
1111
STRING = "STRING",
1212
BOOL = "BOOL",
13+
BYTES = "BYTES",
14+
INT32 = "INT32",
15+
DOUBLE = "DOUBLE",
16+
UNIX_TIMESTAMP = "UNIX_TIMESTAMP"
1317
}
1418

1519
export { FEAST_FCO_TYPES, FEAST_FEATURE_VALUE_TYPES };

0 commit comments

Comments
 (0)