Skip to content

Commit cbcaab6

Browse files
committed
make sure start/end are not optional!
1 parent f7b7d37 commit cbcaab6

File tree

1 file changed

+2
-2
lines changed
  • sdk/python/feast/infra/offline_stores/contrib/clickhouse_offline_store

1 file changed

+2
-2
lines changed

sdk/python/feast/infra/offline_stores/contrib/clickhouse_offline_store/clickhouse.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,9 @@ def pull_all_from_table_or_query(
201201
join_key_columns: List[str],
202202
feature_name_columns: List[str],
203203
timestamp_field: str,
204+
start_date: datetime,
205+
end_date: datetime,
204206
created_timestamp_column: Optional[str] = None,
205-
start_date: Optional[datetime] = None,
206-
end_date: Optional[datetime] = None,
207207
) -> RetrievalJob:
208208
assert isinstance(config.offline_store, ClickhouseOfflineStoreConfig)
209209
assert isinstance(data_source, ClickhouseSource)

0 commit comments

Comments
 (0)