chore: Add tests to bool test type (#3473)

* chore(test): add tests to bool test type

Signed-off-by: gbmarc1 <[email protected]>

* style(isort):  order pytest import

Signed-off-by: gbmarc1 <[email protected]>

---------

Signed-off-by: gbmarc1 <[email protected]>

Author: gbmarc1

sdk/python/feast/type_map.py

@@ -300,7 +300,7 @@ def _type_err(item, dtype):
     ValueType.DOUBLE: ("double_val", lambda x: x, {float, np.float64}),
     ValueType.STRING: ("string_val", lambda x: str(x), None),
     ValueType.BYTES: ("bytes_val", lambda x: x, {bytes}),
-    ValueType.BOOL: ("bool_val", lambda x: x, {bool, np.bool_}),
+    ValueType.BOOL: ("bool_val", lambda x: x, {bool, np.bool_, int, np.int_}),
 }
 
 
@@ -405,9 +405,14 @@ def _python_value_to_proto_value(
             if (sample == 0 or sample == 0.0) and feast_value_type != ValueType.BOOL:
                 # Numpy convert 0 to int. However, in the feature view definition, the type of column may be a float.
                 # So, if value is 0, type validation must pass if scalar_types are either int or float.
-                assert type(sample) in [np.int64, int, np.float64, float]
+                allowed_types = {np.int64, int, np.float64, float}
+                assert (
+                    type(sample) in allowed_types
+                ), f"Type `{type(sample)}` not in {allowed_types}"
             else:
-                assert type(sample) in valid_scalar_types
+                assert (
+                    type(sample) in valid_scalar_types
+                ), f"Type `{type(sample)}` not in {valid_scalar_types}"
         if feast_value_type == ValueType.BOOL:
             # ProtoValue does not support conversion of np.bool_ so we need to convert it to support np.bool_.
             return [

sdk/python/tests/unit/test_type_map.py

@@ -1,4 +1,5 @@
 import numpy as np
+import pytest
 
 from feast.type_map import (
     feast_value_type_to_python_type,
@@ -26,3 +27,24 @@ def test_null_unix_timestamp_list():
     converted = feast_value_type_to_python_type(protos[0])
 
     assert converted[0] is None
+
+
+@pytest.mark.parametrize(
+    "values",
+    (
+        np.array([True]),
+        np.array([False]),
+        np.array([0]),
+        np.array([1]),
+        [True],
+        [False],
+        [0],
+        [1],
+    ),
+)
+def test_python_values_to_proto_values_bool(values):
+
+    protos = python_values_to_proto_values(values, ValueType.BOOL)
+    converted = feast_value_type_to_python_type(protos[0])
+
+    assert converted is bool(values[0])