Skip to content

Commit 9ed2ffa

Browse files
miroslawasLaurynas Stasys
andauthored
fix: Add clickhouse to OFFLINE_STORE_CLASS_FOR_TYPE map (#5251)
* added clickhouse to OFFLINE_STORE_CLASS_FOR_TYPE map Signed-off-by: Laurynas Stasys <[email protected]> * removing redundant brackets from from_expression Signed-off-by: Laurynas Stasys <[email protected]> --------- Signed-off-by: Laurynas Stasys <[email protected]> Co-authored-by: Laurynas Stasys <[email protected]>
1 parent 37d5c19 commit 9ed2ffa

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

sdk/python/feast/infra/offline_stores/contrib/clickhouse_offline_store/clickhouse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ def pull_latest_from_table_or_query(
176176
FROM (
177177
SELECT {a_field_string},
178178
ROW_NUMBER() OVER({partition_by_join_key_string} ORDER BY {timestamp_desc_string}) AS _feast_row
179-
FROM ({from_expression}) a
179+
FROM {from_expression} a
180180
WHERE a."{timestamp_field}"
181181
BETWEEN toDateTime64('{start_date.replace(tzinfo=None)!s}', 6, '{start_date.tzinfo!s}')
182182
AND toDateTime64('{end_date.replace(tzinfo=None)!s}', 6, '{end_date.tzinfo!s}')

sdk/python/feast/repo_config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@
100100
"duckdb": "feast.infra.offline_stores.duckdb.DuckDBOfflineStore",
101101
"remote": "feast.infra.offline_stores.remote.RemoteOfflineStore",
102102
"couchbase.offline": "feast.infra.offline_stores.contrib.couchbase_offline_store.couchbase.CouchbaseColumnarOfflineStore",
103+
"clickhouse": "feast.infra.offline_stores.contrib.clickhouse_offline_store.clickhouse.ClickhouseOfflineStore",
103104
}
104105

105106
FEATURE_SERVER_CONFIG_CLASS_FOR_TYPE = {

0 commit comments

Comments
 (0)