Skip to content

Commit 568058a

Browse files
breno-costakevjumba
authored andcommitted
fix: Change the feature store plan method to public modifier (#2904)
Signed-off-by: Breno Costa <[email protected]>
1 parent f78922e commit 568058a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

sdk/python/feast/feature_store.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -511,8 +511,8 @@ def _get_features(
511511
return _feature_refs
512512

513513
def _should_use_plan(self):
514-
"""Returns True if _plan and _apply_diffs should be used, False otherwise."""
515-
# Currently only the local provider with sqlite online store supports _plan and _apply_diffs.
514+
"""Returns True if plan and _apply_diffs should be used, False otherwise."""
515+
# Currently only the local provider with sqlite online store supports plan and _apply_diffs.
516516
return self.config.provider == "local" and (
517517
self.config.online_store and self.config.online_store.type == "sqlite"
518518
)
@@ -636,7 +636,7 @@ def _get_feature_views_to_materialize(
636636
return feature_views_to_materialize
637637

638638
@log_exceptions_and_usage
639-
def _plan(
639+
def plan(
640640
self, desired_repo_contents: RepoContents
641641
) -> Tuple[RegistryDiff, InfraDiff, Infra]:
642642
"""Dry-run registering objects to metadata store.
@@ -670,7 +670,7 @@ def _plan(
670670
... ttl=timedelta(seconds=86400 * 1),
671671
... batch_source=driver_hourly_stats,
672672
... )
673-
>>> registry_diff, infra_diff, new_infra = fs._plan(RepoContents(
673+
>>> registry_diff, infra_diff, new_infra = fs.plan(RepoContents(
674674
... data_sources=[driver_hourly_stats],
675675
... feature_views=[driver_hourly_stats_view],
676676
... on_demand_feature_views=list(),

sdk/python/feast/repo_operations.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ def plan(repo_config: RepoConfig, repo_path: Path, skip_source_validation: bool)
183183
for data_source in data_sources:
184184
data_source.validate(store.config)
185185

186-
registry_diff, infra_diff, _ = store._plan(repo)
186+
registry_diff, infra_diff, _ = store.plan(repo)
187187
click.echo(registry_diff.to_string())
188188
click.echo(infra_diff.to_string())
189189

@@ -262,7 +262,7 @@ def apply_total_with_repo_instance(
262262
for data_source in data_sources:
263263
data_source.validate(store.config)
264264

265-
registry_diff, infra_diff, new_infra = store._plan(repo)
265+
registry_diff, infra_diff, new_infra = store.plan(repo)
266266

267267
# For each object in the registry, determine whether it should be kept or deleted.
268268
(

0 commit comments

Comments
 (0)