Review

Author: topilski

src/proxy/cluster_connection_settings_factory.cpp

@@ -63,7 +63,7 @@ IClusterSettingsBase* ClusterConnectionSettingsFactory::CreateFromStringCluster(
   }
 
   IClusterSettingsBase* result = nullptr;
-  size_t value_len = value.size();
+  const size_t value_len = value.size();
 
   uint8_t comma_count = 0;
   serialize_t element_text;

src/proxy/command/command_logger.cpp

@@ -31,5 +31,9 @@ void CommandLogger::Print(core::FastoObjectCommandIPtr command) {
   emit Printed(command);
 }
 
+void LOG_COMMAND(core::FastoObjectCommandIPtr command) {
+  return CommandLogger::GetInstance().Print(command);
+}
+
 }  // namespace proxy
 }  // namespace fastonosql

src/proxy/command/command_logger.h

@@ -41,9 +41,7 @@ class CommandLogger : public QObject, public common::patterns::LazySingleton<Com
   CommandLogger();
 };
 
-inline void LOG_COMMAND(core::FastoObjectCommandIPtr command) {
-  return CommandLogger::GetInstance().Print(command);
-}
+void LOG_COMMAND(core::FastoObjectCommandIPtr command);
 
 }  // namespace proxy
 }  // namespace fastonosql

src/proxy/user_info.cpp

@@ -28,17 +28,7 @@ const char* kBuildStrategy[] = {"community", "public", "private"};
 namespace fastonosql {
 namespace proxy {
 
-UserInfo::UserInfo()
-    : login_(),
-      password_(),
-      build_strategy_(),
-      first_name_(),
-      last_name_(),
-      subscription_state_(UNSUBSCIRBED),
-      type_(USER),
-      exec_count_(0),
-      expire_time_(0),
-      user_id_() {}
+UserInfo::UserInfo() : UserInfo(std::string(), std::string(), COMMUNITY_BUILD) {}
 
 UserInfo::UserInfo(const std::string& login, const std::string& password, BuildStrategy strategy)
     : login_(login),