chore: improve error messages in Login and ClientForRegistry

loresuso · poiana · commit f566ad6e4098 · 2022-12-15T11:55:19.000+01:00
Signed-off-by: Lorenzo Susini &lt;susinilorenzo1@gmail.com&gt;
diff --git a/internal/registry/login/login.go b/internal/registry/login/login.go
@@ -91,7 +91,7 @@ func (o *loginOptions) RunLogin(ctx context.Context, args []string) error {
 
 	if err := utils.CheckRegistryConnection(ctx, cred, registry, o.Printer); err != nil {
 		o.Printer.Verbosef("%s", err.Error())
-		return fmt.Errorf("unable to connect to registry %q", registry)
+		return fmt.Errorf("unable to connect to registry %q: %w", registry, err)
 	}
 
 	// Store validated credentials
diff --git a/internal/utils/registry.go b/internal/utils/registry.go
@@ -61,7 +61,7 @@ func ClientForRegistry(ctx context.Context, registry string, printer *output.Pri
 
 	if err := CheckRegistryConnection(ctx, &cred, registry, printer); err != nil {
 		printer.Verbosef("%s", err.Error())
-		return nil, fmt.Errorf("unable to connect to registry %q", registry)
+		return nil, fmt.Errorf("unable to connect to registry %q: %w", registry, err)
 	}
 
 	return authn.NewClient(cred), err

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ func (o *loginOptions) RunLogin(ctx context.Context, args []string) error {`
`91`	`91`
`92`	`92`	`if err := utils.CheckRegistryConnection(ctx, cred, registry, o.Printer); err != nil {`
`93`	`93`	`o.Printer.Verbosef("%s", err.Error())`
`94`		`- return fmt.Errorf("unable to connect to registry %q", registry)`
	`94`	`+ return fmt.Errorf("unable to connect to registry %q: %w", registry, err)`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`// Store validated credentials`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ func ClientForRegistry(ctx context.Context, registry string, printer *output.Pri`
`61`	`61`
`62`	`62`	`if err := CheckRegistryConnection(ctx, &cred, registry, printer); err != nil {`
`63`	`63`	`printer.Verbosef("%s", err.Error())`
`64`		`- return nil, fmt.Errorf("unable to connect to registry %q", registry)`
	`64`	`+ return nil, fmt.Errorf("unable to connect to registry %q: %w", registry, err)`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`return authn.NewClient(cred), err`