Skip to content

[activity] remove ref for now #32645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

rickhanlonii
Copy link
Member

Followup from #32499

Manual mode is unused and has some bugs such as revealing hidden boundaries when manually toggling. We also want to change how manual mode works, and do some refactors to Activity to make it easier to support. For now we'll remove it, then add it back after the other changes we have planned.

@react-sizebot
Copy link

Comparing: cd28a94...2406c72

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 515.14 kB = 92.26 kB 91.74 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 605.55 kB 603.39 kB = 107.43 kB 106.73 kB
facebook-www/ReactDOM-prod.classic.js = 651.92 kB 648.72 kB = 114.83 kB 114.38 kB
facebook-www/ReactDOM-prod.modern.js = 642.20 kB 639.00 kB = 113.24 kB 112.81 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,107.02 kB 1,104.58 kB = 186.18 kB 185.38 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js = 1,106.50 kB 1,104.06 kB = 185.22 kB 184.46 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js = 1,090.11 kB 1,087.66 kB = 182.39 kB 181.61 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js = 1,012.44 kB 1,010.00 kB = 170.25 kB 169.52 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js = 996.12 kB 993.67 kB = 167.40 kB 166.69 kB
test_utils/ReactAllWarnings.js = 63.93 kB 63.77 kB = 16.00 kB 15.95 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js = 968.29 kB 965.84 kB = 163.56 kB 162.92 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js = 968.17 kB 965.72 kB = 163.53 kB 162.89 kB
oss-stable/react-dom/cjs/react-dom-client.development.js = 951.85 kB 949.40 kB = 160.72 kB 160.09 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js = 951.73 kB 949.28 kB = 160.70 kB 160.07 kB
oss-experimental/react-dom/cjs/react-dom-profiling.profiling.js = 660.99 kB 658.82 kB = 116.16 kB 115.61 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,193.96 kB 1,189.97 kB = 199.20 kB 198.57 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,184.82 kB 1,180.83 kB = 197.41 kB 196.81 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 677.12 kB 674.85 kB = 110.19 kB 109.88 kB
facebook-www/ReactDOM-dev.classic.js = 1,177.42 kB 1,173.44 kB = 195.35 kB 194.71 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 755.59 kB 753.02 kB = 118.82 kB 118.45 kB
facebook-www/ReactDOM-dev.modern.js = 1,168.28 kB 1,164.30 kB = 193.60 kB 193.02 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js = 620.28 kB 618.12 kB = 111.03 kB 110.36 kB
react-native/implementations/ReactNativeRenderer-dev.js = 650.27 kB 647.99 kB = 106.07 kB 105.79 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 605.55 kB 603.39 kB = 107.43 kB 106.73 kB
oss-experimental/react-art/cjs/react-art.development.js = 631.09 kB 628.80 kB = 100.08 kB 99.78 kB
react-native/implementations/ReactFabric-dev.fb.js = 672.35 kB 669.91 kB = 109.30 kB 109.01 kB
facebook-www/ReactReconciler-dev.classic.js = 819.21 kB 816.23 kB = 127.96 kB 127.54 kB
facebook-www/ReactReconciler-dev.modern.js = 810.01 kB 807.02 kB = 126.29 kB 125.90 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 600.23 kB 597.95 kB = 96.69 kB 96.37 kB
facebook-www/ReactART-dev.classic.js = 710.34 kB 707.64 kB = 111.38 kB 111.05 kB
react-native/implementations/ReactFabric-dev.js = 641.90 kB 639.46 kB = 104.74 kB 104.41 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js = 576.10 kB 573.90 kB = 101.72 kB 101.17 kB
facebook-www/ReactART-dev.modern.js = 700.85 kB 698.15 kB = 109.54 kB 109.21 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js = 570.16 kB 567.96 kB = 100.57 kB 100.01 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js = 550.81 kB 548.67 kB = 97.90 kB 97.42 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js = 545.30 kB 543.17 kB = 96.83 kB 96.34 kB
facebook-www/ReactTestRenderer-dev.classic.js = 577.17 kB 574.89 kB = 93.87 kB 93.57 kB
facebook-www/ReactTestRenderer-dev.modern.js = 577.17 kB 574.89 kB = 93.87 kB 93.57 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 647.45 kB 644.88 kB = 103.28 kB 102.84 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js = 647.43 kB 644.85 kB = 103.25 kB 102.81 kB
oss-stable/react-dom/cjs/react-dom-profiling.profiling.js = 547.70 kB 545.48 kB = 96.97 kB 96.46 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js = 547.57 kB 545.35 kB = 96.94 kB 96.43 kB
oss-stable/react-art/cjs/react-art.development.js = 560.25 kB 557.96 kB = 90.12 kB 89.82 kB
oss-stable-semver/react-art/cjs/react-art.development.js = 560.17 kB 557.89 kB = 90.10 kB 89.80 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 559.29 kB 557.00 kB = 90.81 kB 90.53 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 559.24 kB 556.96 kB = 90.80 kB 90.52 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js = 559.21 kB 556.93 kB = 90.79 kB 90.50 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 515.14 kB = 92.26 kB 91.74 kB
oss-stable-semver/react-dom/cjs/react-dom-client.production.js = 517.17 kB 515.02 kB = 92.23 kB 91.71 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js = 512.38 kB 510.08 kB = 81.69 kB 81.39 kB
facebook-www/ReactDOM-profiling.classic.js = 714.85 kB 711.63 kB = 123.96 kB 123.51 kB
facebook-www/ReactDOM-profiling.modern.js = 706.81 kB 703.58 kB = 122.62 kB 122.16 kB
facebook-www/ReactDOMTesting-prod.classic.js = 666.32 kB 663.12 kB = 118.49 kB 118.04 kB
facebook-www/ReactDOMTesting-prod.modern.js = 656.60 kB 653.40 kB = 116.86 kB 116.44 kB
facebook-www/ReactDOM-prod.classic.js = 651.92 kB 648.72 kB = 114.83 kB 114.38 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js = 459.38 kB 457.12 kB = 73.74 kB 73.46 kB
facebook-www/ReactDOM-prod.modern.js = 642.20 kB 639.00 kB = 113.24 kB 112.81 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 411.46 kB 409.40 kB = 70.87 kB 70.58 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 385.95 kB 383.94 kB = 67.03 kB 66.72 kB
react-native/implementations/ReactNativeRenderer-profiling.js = 392.93 kB 390.87 kB = 67.56 kB 67.28 kB
facebook-www/ReactReconciler-prod.classic.js = 501.86 kB 499.18 kB = 80.35 kB 79.97 kB
react-native/implementations/ReactFabric-profiling.fb.js = 407.95 kB 405.76 kB = 70.28 kB 69.98 kB
facebook-www/ReactReconciler-prod.modern.js = 491.55 kB 488.88 kB = 78.74 kB 78.37 kB
react-native/implementations/ReactNativeRenderer-prod.js = 367.58 kB 365.56 kB = 63.75 kB 63.41 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.js = 419.25 kB 416.95 kB = 67.46 kB 67.14 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js = 419.22 kB 416.92 kB = 67.43 kB 67.12 kB
react-native/implementations/ReactFabric-prod.fb.js = 382.44 kB 380.30 kB = 66.40 kB 66.07 kB
oss-experimental/react-art/cjs/react-art.production.js = 335.83 kB 333.93 kB = 56.75 kB 56.48 kB
react-native/implementations/ReactFabric-profiling.js = 385.63 kB 383.44 kB = 66.36 kB 66.07 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.js = 393.06 kB 390.80 kB = 63.79 kB 63.45 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js = 393.04 kB 390.78 kB = 63.77 kB 63.42 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 357.70 kB 355.64 kB = 61.67 kB 61.42 kB
facebook-www/ReactART-prod.classic.js = 386.18 kB 383.89 kB = 64.85 kB 64.52 kB
react-native/implementations/ReactFabric-prod.js = 360.39 kB 358.24 kB = 62.64 kB 62.33 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 335.52 kB 333.51 kB = 58.50 kB 58.22 kB
facebook-www/ReactART-prod.modern.js = 376.19 kB 373.91 kB = 63.21 kB 62.89 kB
oss-stable/react-art/cjs/react-art.production.js = 302.62 kB 300.72 kB = 51.46 kB 51.16 kB
oss-stable-semver/react-art/cjs/react-art.production.js = 302.54 kB 300.65 kB = 51.43 kB 51.13 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js = 314.91 kB 312.88 kB = 55.21 kB 54.90 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js = 314.74 kB 312.71 kB = 55.18 kB 54.86 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js = 314.66 kB 312.64 kB = 55.15 kB 54.84 kB

Generated by 🚫 dangerJS against a69916b

@rickhanlonii rickhanlonii merged commit daee085 into facebook:main Mar 21, 2025
194 checks passed
@rickhanlonii rickhanlonii deleted the rh/remove-manual-mode branch March 21, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants