Skip to content

Commit e6de1af

Browse files
committed
Updated strict-mode fb.me link (and tests)
1 parent 14211e5 commit e6de1af

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

packages/react-reconciler/src/ReactStrictModeWarnings.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,10 @@ if (__DEV__) {
7777

7878
warning(
7979
false,
80-
'Unsafe lifecycle methods were found within the following async tree:%s' +
80+
'Unsafe lifecycle methods were found within a strict-mode tree:%s' +
8181
'\n\n%s' +
8282
'\n\nLearn more about this warning here:' +
83-
'\nhttps://fb.me/react-async-component-lifecycle-hooks',
83+
'\nhttps://fb.me/react-strict-mode-warnings',
8484
strictRootComponentStack,
8585
lifecyclesWarningMesages.join('\n\n'),
8686
);

packages/react/src/__tests__/ReactAsyncClassComponent-test.internal.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ describe('ReactAsyncClassComponent', () => {
181181
expect(() => {
182182
rendered = ReactTestRenderer.create(<SyncRoot />);
183183
}).toWarnDev(
184-
'Unsafe lifecycle methods were found within the following async tree:' +
184+
'Unsafe lifecycle methods were found within a strict-mode tree:' +
185185
'\n in AsyncRoot (at **)' +
186186
'\n in SyncRoot (at **)' +
187187
'\n\ncomponentWillMount: Please update the following components ' +
@@ -191,7 +191,7 @@ describe('ReactAsyncClassComponent', () => {
191191
'\n\ncomponentWillUpdate: Please update the following components ' +
192192
'to use componentDidUpdate instead: AsyncRoot' +
193193
'\n\nLearn more about this warning here:' +
194-
'\nhttps://fb.me/react-async-component-lifecycle-hooks',
194+
'\nhttps://fb.me/react-strict-mode-warnings',
195195
);
196196

197197
// Dedupe
@@ -235,7 +235,7 @@ describe('ReactAsyncClassComponent', () => {
235235
expect(
236236
() => (rendered = ReactTestRenderer.create(<SyncRoot />)),
237237
).toWarnDev(
238-
'Unsafe lifecycle methods were found within the following async tree:' +
238+
'Unsafe lifecycle methods were found within a strict-mode tree:' +
239239
'\n in AsyncRoot (at **)' +
240240
'\n in SyncRoot (at **)' +
241241
'\n\ncomponentWillMount: Please update the following components ' +
@@ -245,7 +245,7 @@ describe('ReactAsyncClassComponent', () => {
245245
'\n\ncomponentWillUpdate: Please update the following components ' +
246246
'to use componentDidUpdate instead: AsyncRoot, Parent' +
247247
'\n\nLearn more about this warning here:' +
248-
'\nhttps://fb.me/react-async-component-lifecycle-hooks',
248+
'\nhttps://fb.me/react-strict-mode-warnings',
249249
);
250250

251251
// Dedupe
@@ -309,13 +309,13 @@ describe('ReactAsyncClassComponent', () => {
309309
expect(
310310
() => (rendered = ReactTestRenderer.create(<SyncRoot />)),
311311
).toWarnDev([
312-
'Unsafe lifecycle methods were found within the following async tree:' +
312+
'Unsafe lifecycle methods were found within a strict-mode tree:' +
313313
'\n in AsyncRootOne (at **)' +
314314
'\n in div (at **)' +
315315
'\n in SyncRoot (at **)' +
316316
'\n\ncomponentWillMount: Please update the following components ' +
317317
'to use componentDidMount instead: Bar, Foo',
318-
'Unsafe lifecycle methods were found within the following async tree:' +
318+
'Unsafe lifecycle methods were found within a strict-mode tree:' +
319319
'\n in AsyncRootTwo (at **)' +
320320
'\n in div (at **)' +
321321
'\n in SyncRoot (at **)' +
@@ -351,21 +351,21 @@ describe('ReactAsyncClassComponent', () => {
351351
expect(() => {
352352
rendered = ReactTestRenderer.create(<AsyncRoot foo={true} />);
353353
}).toWarnDev(
354-
'Unsafe lifecycle methods were found within the following async tree:' +
354+
'Unsafe lifecycle methods were found within a strict-mode tree:' +
355355
'\n in AsyncRoot (at **)' +
356356
'\n\ncomponentWillMount: Please update the following components ' +
357357
'to use componentDidMount instead: Foo' +
358358
'\n\nLearn more about this warning here:' +
359-
'\nhttps://fb.me/react-async-component-lifecycle-hooks',
359+
'\nhttps://fb.me/react-strict-mode-warnings',
360360
);
361361

362362
expect(() => rendered.update(<AsyncRoot foo={false} />)).toWarnDev(
363-
'Unsafe lifecycle methods were found within the following async tree:' +
363+
'Unsafe lifecycle methods were found within a strict-mode tree:' +
364364
'\n in AsyncRoot (at **)' +
365365
'\n\ncomponentWillMount: Please update the following components ' +
366366
'to use componentDidMount instead: Bar' +
367367
'\n\nLearn more about this warning here:' +
368-
'\nhttps://fb.me/react-async-component-lifecycle-hooks',
368+
'\nhttps://fb.me/react-strict-mode-warnings',
369369
);
370370

371371
// Dedupe
@@ -409,12 +409,12 @@ describe('ReactAsyncClassComponent', () => {
409409
expect(() => {
410410
ReactTestRenderer.create(<AsyncRoot foo={true} />);
411411
}).toWarnDev(
412-
'Unsafe lifecycle methods were found within the following async tree:' +
412+
'Unsafe lifecycle methods were found within a strict-mode tree:' +
413413
'\n in AsyncRoot (at **)' +
414414
'\n\ncomponentWillMount: Please update the following components ' +
415415
'to use componentDidMount instead: Bar' +
416416
'\n\nLearn more about this warning here:' +
417-
'\nhttps://fb.me/react-async-component-lifecycle-hooks',
417+
'\nhttps://fb.me/react-strict-mode-warnings',
418418
);
419419

420420
expect(caughtError).not.toBe(null);
@@ -457,15 +457,15 @@ describe('ReactAsyncClassComponent', () => {
457457
}
458458

459459
expect(() => ReactTestRenderer.create(<SyncRoot />)).toWarnDev(
460-
'Unsafe lifecycle methods were found within the following async tree:' +
460+
'Unsafe lifecycle methods were found within a strict-mode tree:' +
461461
'\n in PreAsyncRoot (at **)' +
462462
'\n in SyncRoot (at **)' +
463463
'\n\ncomponentWillMount: Please update the following components ' +
464464
'to use componentDidMount instead: PreAsyncRoot' +
465465
'\n\ncomponentWillReceiveProps: Please update the following components ' +
466466
'to use static getDerivedStateFromProps instead: Bar, Foo' +
467467
'\n\nLearn more about this warning here:' +
468-
'\nhttps://fb.me/react-async-component-lifecycle-hooks',
468+
'\nhttps://fb.me/react-strict-mode-warnings',
469469
);
470470

471471
// Dedupe

0 commit comments

Comments
 (0)