Consistently encode

Author: eps1lon

packages/react-client/src/ReactClientStackConfigWeb.js

@@ -52,7 +52,6 @@ import {
 } from 'shared/ReactFeatureFlags';
 
 import {
-  getSourceURL,
   resolveClientReference,
   resolveServerReference,
   preloadModule,
@@ -2753,32 +2752,25 @@ function createFakeFunction<T>(
     code = comment + code;
   }
 
-  if (filename.startsWith('/')) {
-    // If the filename starts with `/` we assume that it is a file system file
-    // rather than relative to the current host. Since on the server fully qualified
-    // stack traces use the file path.
-    // TODO: What does this look like on Windows?
-    filename = 'file://' + filename;
-  }
-
+  // We use the prefix rsc://React/ to separate these from other files listed in
+  // the Chrome DevTools. We need a "host name" and not just a protocol because
+  // otherwise the group name becomes the root folder. Ideally we don't want to
+  // show these at all but there's two reasons to assign a fake URL.
+  // 1) A printed stack trace string needs a unique URL to be able to source map it.
+  // 2) If source maps are disabled or fails, you should at least be able to tell
+  //    which file it was.
+  const sourceURL =
+    'rsc://React/' +
+    encodeURIComponent(environmentName) +
+    '/' +
+    encodeURI(filename) +
+    '?' +
+    fakeFunctionIdx++;
   if (sourceMap) {
-    // We use the prefix rsc://React/ to separate these from other files listed in
-    // the Chrome DevTools. We need a "host name" and not just a protocol because
-    // otherwise the group name becomes the root folder. Ideally we don't want to
-    // show these at all but there's two reasons to assign a fake URL.
-    // 1) A printed stack trace string needs a unique URL to be able to source map it.
-    // 2) If source maps are disabled or fails, you should at least be able to tell
-    //    which file it was.
-    code +=
-      '\n//# sourceURL=rsc://React/' +
-      encodeURIComponent(environmentName) +
-      '/' +
-      getSourceURL(filename) +
-      '?' +
-      fakeFunctionIdx++;
+    code += '\n//# sourceURL=' + sourceURL;
     code += '\n//# sourceMappingURL=' + sourceMap;
   } else if (filename) {
-    code += '\n//# sourceURL=' + getSourceURL(filename);
+    code += '\n//# sourceURL=' + sourceURL;
   } else {
     code += '\n//# sourceURL=<anonymous>';
   }

packages/react-client/src/ReactFlightClient.js

@@ -52,5 +52,3 @@ export const bindToConsole = $$$config.bindToConsole;
 
 export const rendererVersion = $$$config.rendererVersion;
 export const rendererPackageName = $$$config.rendererPackageName;
-
-export const getSourceURL = $$$config.getSourceURL;

packages/react-client/src/forks/ReactFlightClientConfig.custom.js

@@ -10,7 +10,6 @@
 export {default as rendererVersion} from 'shared/ReactVersion';
 export const rendererPackageName = 'react-server-dom-esm';
 
-export * from 'react-client/src/ReactClientStackConfigWeb';
 export * from 'react-client/src/ReactFlightClientStreamConfigWeb';
 export * from 'react-client/src/ReactClientConsoleConfigBrowser';
 export * from 'react-server-dom-esm/src/client/ReactFlightClientConfigBundlerESM';

packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-esm.js

@@ -10,7 +10,6 @@
 export {default as rendererVersion} from 'shared/ReactVersion';
 export const rendererPackageName = 'react-server-dom-parcel';
 
-export * from 'react-client/src/ReactClientStackConfigWeb';
 export * from 'react-client/src/ReactFlightClientStreamConfigWeb';
 export * from 'react-client/src/ReactClientConsoleConfigBrowser';
 export * from 'react-server-dom-parcel/src/client/ReactFlightClientConfigBundlerParcel';

packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-parcel.js

@@ -10,7 +10,6 @@
 export {default as rendererVersion} from 'shared/ReactVersion';
 export const rendererPackageName = 'react-server-dom-turbopack';
 
-export * from 'react-client/src/ReactClientStackConfigWeb';
 export * from 'react-client/src/ReactFlightClientStreamConfigWeb';
 export * from 'react-client/src/ReactClientConsoleConfigBrowser';
 export * from 'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopack';

packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-turbopack.js

@@ -10,7 +10,6 @@
 export {default as rendererVersion} from 'shared/ReactVersion';
 export const rendererPackageName = 'react-server-dom-webpack';
 
-export * from 'react-client/src/ReactClientStackConfigWeb';
 export * from 'react-client/src/ReactFlightClientStreamConfigWeb';
 export * from 'react-client/src/ReactClientConsoleConfigBrowser';
 export * from 'react-server-dom-webpack/src/client/ReactFlightClientConfigBundlerWebpack';

packages/react-client/src/forks/ReactFlightClientConfig.dom-browser.js

@@ -10,7 +10,6 @@
 export {default as rendererVersion} from 'shared/ReactVersion';
 export const rendererPackageName = 'react-server-dom-bun';
 
-export * from 'react-client/src/ReactClientStackConfigWeb';
 export * from 'react-client/src/ReactFlightClientStreamConfigWeb';
 export * from 'react-client/src/ReactClientConsoleConfigPlain';
 export * from 'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

packages/react-client/src/forks/ReactFlightClientConfig.dom-bun.js

@@ -10,7 +10,6 @@
 export {default as rendererVersion} from 'shared/ReactVersion';
 export const rendererPackageName = 'react-server-dom-parcel';
 
-export * from 'react-client/src/ReactClientStackConfigWeb';
 export * from 'react-client/src/ReactFlightClientStreamConfigWeb';
 export * from 'react-client/src/ReactClientConsoleConfigServer';
 export * from 'react-server-dom-parcel/src/client/ReactFlightClientConfigBundlerParcel';

packages/react-client/src/forks/ReactFlightClientConfig.dom-edge-parcel.js

@@ -10,7 +10,6 @@
 export {default as rendererVersion} from 'shared/ReactVersion';
 export const rendererPackageName = 'react-server-dom-turbopack';
 
-export * from 'react-client/src/ReactClientStackConfigWeb';
 export * from 'react-client/src/ReactFlightClientStreamConfigWeb';
 export * from 'react-client/src/ReactClientConsoleConfigServer';
 export * from 'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopack';