Skip to content

Commit b80a98a

Browse files
committed
Clean up enableSyncDefaultUpdates flag a bit (#26858)
## Overview Does a few things: - Renames `enableSyncDefaultUpdates` to `forceConcurrentByDefaultForTesting` - Changes the way it's used so it's dead-code eliminated separate from `allowConcurrentByDefault` - Deletes a bunch of the gated code The gates that are deleted are unnecessary now. We were keeping them when we originally thought we would come back to being concurrent by default. But we've shifted and now sync-by default is the desired behavior long term, so there's no need to keep all these forked tests around. I'll follow up to delete more of the forked behavior if possible. Ideally we wouldn't need this flag even if we're still using `allowConcurrentByDefault`. DiffTrain build for commit 018c58c.
1 parent 4c0c82b commit b80a98a

File tree

9 files changed

+14
-20
lines changed

9 files changed

+14
-20
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<ca59e5754dbc2396cdc2b7d218cedd13>>
10+
* @generated SignedSource<<e2649a21f4471fab672f885dc7d27434>>
1111
*/
1212

1313
'use strict';
@@ -23529,8 +23529,6 @@ function createHostRootFiber(
2352923529
}
2353023530

2353123531
if (
23532-
// We only use this flag for our repo tests to check both behaviors.
23533-
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
2353423532
// Only for internal experiments.
2353523533
concurrentUpdatesByDefaultOverride
2353623534
) {
@@ -23930,7 +23928,7 @@ function createFiberRoot(
2393023928
return root;
2393123929
}
2393223930

23933-
var ReactVersion = "18.3.0-canary-ae31d2ea3-20230531";
23931+
var ReactVersion = "18.3.0-canary-018c58c9c-20230601";
2393423932

2393523933
// Might add PROFILE later.
2393623934

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8617,7 +8617,7 @@ var devToolsConfig$jscomp$inline_1036 = {
86178617
throw Error("TestRenderer does not support findFiberByHostInstance()");
86188618
},
86198619
bundleType: 0,
8620-
version: "18.3.0-canary-ae31d2ea3-20230531",
8620+
version: "18.3.0-canary-018c58c9c-20230601",
86218621
rendererPackageName: "react-test-renderer"
86228622
};
86238623
var internals$jscomp$inline_1235 = {
@@ -8648,7 +8648,7 @@ var internals$jscomp$inline_1235 = {
86488648
scheduleRoot: null,
86498649
setRefreshHandler: null,
86508650
getCurrentFiber: null,
8651-
reconcilerVersion: "18.3.0-canary-ae31d2ea3-20230531"
8651+
reconcilerVersion: "18.3.0-canary-018c58c9c-20230601"
86528652
};
86538653
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
86548654
var hook$jscomp$inline_1236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9043,7 +9043,7 @@ var devToolsConfig$jscomp$inline_1078 = {
90439043
throw Error("TestRenderer does not support findFiberByHostInstance()");
90449044
},
90459045
bundleType: 0,
9046-
version: "18.3.0-canary-ae31d2ea3-20230531",
9046+
version: "18.3.0-canary-018c58c9c-20230601",
90479047
rendererPackageName: "react-test-renderer"
90489048
};
90499049
var internals$jscomp$inline_1276 = {
@@ -9074,7 +9074,7 @@ var internals$jscomp$inline_1276 = {
90749074
scheduleRoot: null,
90759075
setRefreshHandler: null,
90769076
getCurrentFiber: null,
9077-
reconcilerVersion: "18.3.0-canary-ae31d2ea3-20230531"
9077+
reconcilerVersion: "18.3.0-canary-018c58c9c-20230601"
90789078
};
90799079
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
90809080
var hook$jscomp$inline_1277 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-canary-ae31d2ea3-20230531";
30+
var ReactVersion = "18.3.0-canary-018c58c9c-20230601";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,4 +642,4 @@ exports.useSyncExternalStore = function (
642642
);
643643
};
644644
exports.useTransition = useTransition;
645-
exports.version = "18.3.0-canary-ae31d2ea3-20230531";
645+
exports.version = "18.3.0-canary-018c58c9c-20230601";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ exports.useSyncExternalStore = function (
645645
);
646646
};
647647
exports.useTransition = useTransition;
648-
exports.version = "18.3.0-canary-ae31d2ea3-20230531";
648+
exports.version = "18.3.0-canary-018c58c9c-20230601";
649649

650650
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
651651
if (
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ae31d2ea3c3f9f0a87ff2c6193484d5d8786bc5f
1+
018c58c9c65452cff25aaf1f38f78a9b90d8e5c1

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<130672a53893af8813c0dcaa40c799e0>>
10+
* @generated SignedSource<<4a2e654ac2f9287b5e09859cfc8873f1>>
1111
*/
1212

1313
'use strict';
@@ -26786,8 +26786,6 @@ function createHostRootFiber(
2678626786
}
2678726787

2678826788
if (
26789-
// We only use this flag for our repo tests to check both behaviors.
26790-
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
2679126789
// Only for internal experiments.
2679226790
concurrentUpdatesByDefaultOverride
2679326791
) {
@@ -27246,7 +27244,7 @@ function createFiberRoot(
2724627244
return root;
2724727245
}
2724827246

27249-
var ReactVersion = "18.3.0-canary-4ecba8f8";
27247+
var ReactVersion = "18.3.0-canary-14cb1992";
2725027248

2725127249
function createPortal$1(
2725227250
children,

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<6bfa1b804011279825ec23eadae41f68>>
10+
* @generated SignedSource<<c72d55f3b541b5fe0820ed08c05813c8>>
1111
*/
1212

1313
'use strict';
@@ -27300,8 +27300,6 @@ function createHostRootFiber(
2730027300
}
2730127301

2730227302
if (
27303-
// We only use this flag for our repo tests to check both behaviors.
27304-
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
2730527303
// Only for internal experiments.
2730627304
concurrentUpdatesByDefaultOverride
2730727305
) {
@@ -27760,7 +27758,7 @@ function createFiberRoot(
2776027758
return root;
2776127759
}
2776227760

27763-
var ReactVersion = "18.3.0-canary-2ce08e7a";
27761+
var ReactVersion = "18.3.0-canary-e9eddf24";
2776427762

2776527763
function createPortal$1(
2776627764
children,

0 commit comments

Comments
 (0)