[eslint] Do not allow useEffectEvent fns to be called in arbitrary closures (#33544)

Summary:

useEffectEvent is meant to be used specifically in combination with
useEffect, and using
the feature in arbitrary closures can lead to surprising reactivity
semantics. In order to
minimize risk in the experimental rollout, we are going to restrict its
usage to being
called directly inside an effect or another useEffectEvent, effectively
enforcing the function
coloring statically. Without an effect system this is the best we can
do.

DiffTrain build for [97cdd5d](97cdd5d)

Author: jbrown215

compiled/eslint-plugin-react-hooks/index.js

@@ -55210,13 +55210,15 @@ const rule = {
                 }
             },
             Identifier(node) {
-                if (lastEffect == null &&
-                    useEffectEventFunctions.has(node) &&
-                    node.parent.type !== 'CallExpression') {
+                if (lastEffect == null && useEffectEventFunctions.has(node)) {
+                    const message = `\`${getSourceCode().getText(node)}\` is a function created with React Hook "useEffectEvent", and can only be called from ` +
+                        'the same component.' +
+                        (node.parent.type === 'CallExpression'
+                            ? ''
+                            : ' They cannot be assigned to variables or passed down.');
                     context.report({
                         node,
-                        message: `\`${getSourceCode().getText(node)}\` is a function created with React Hook "useEffectEvent", and can only be called from ` +
-                            'the same component. They cannot be assigned to variables or passed down.',
+                        message,
                     });
                 }
             },

compiled/facebook-www/REVISION

@@ -1 +1 @@
-96c61b7f1f145b9fe5103051b636959cdeb20cc8
+97cdd5d3c33eda77be4f96a43f72d6916d3badbb

compiled/facebook-www/REVISION_TRANSFORMS

@@ -1 +1 @@
-96c61b7f1f145b9fe5103051b636959cdeb20cc8
+97cdd5d3c33eda77be4f96a43f72d6916d3badbb

compiled/facebook-www/React-dev.classic.js

@@ -1434,7 +1434,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-classic-96c61b7f-20250709";
+    exports.version = "19.2.0-www-classic-97cdd5d3-20250710";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

@@ -1434,7 +1434,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-modern-96c61b7f-20250709";
+    exports.version = "19.2.0-www-modern-97cdd5d3-20250710";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-96c61b7f-20250709";
+exports.version = "19.2.0-www-classic-97cdd5d3-20250710";

compiled/facebook-www/React-prod.modern.js

@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-96c61b7f-20250709";
+exports.version = "19.2.0-www-modern-97cdd5d3-20250710";

compiled/facebook-www/React-profiling.classic.js

@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-96c61b7f-20250709";
+exports.version = "19.2.0-www-classic-97cdd5d3-20250710";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-96c61b7f-20250709";
+exports.version = "19.2.0-www-modern-97cdd5d3-20250710";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

@@ -19299,10 +19299,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.2.0-www-classic-96c61b7f-20250709",
+        version: "19.2.0-www-classic-97cdd5d3-20250710",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.2.0-www-classic-96c61b7f-20250709"
+        reconcilerVersion: "19.2.0-www-classic-97cdd5d3-20250710"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19336,7 +19336,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.2.0-www-classic-96c61b7f-20250709";
+    exports.version = "19.2.0-www-classic-97cdd5d3-20250710";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&