rename eslint config file & update eslint rules

Author: ctxhou

packages/react-dom/src/__tests__/ReactDOMComponent-test.js

@@ -443,10 +443,10 @@ describe('ReactDOMComponent', () => {
     });
 
     it('should not set null/undefined attributes', () => {
-      var container = document.createElement('div');
+      const container = document.createElement('div');
       // Initial render.
       ReactDOM.render(<img src={null} data-foo={undefined} />, container);
-      var node = container.firstChild;
+      const node = container.firstChild;
       expect(node.hasAttribute('src')).toBe(false);
       expect(node.hasAttribute('data-foo')).toBe(false);
       // Update in one direction.
@@ -468,9 +468,9 @@ describe('ReactDOMComponent', () => {
     });
 
     it('should apply React-specific aliases to HTML elements', () => {
-      var container = document.createElement('div');
+      const container = document.createElement('div');
       ReactDOM.render(<form acceptCharset="foo" />, container);
-      var node = container.firstChild;
+      const node = container.firstChild;
       // Test attribute initialization.
       expect(node.getAttribute('accept-charset')).toBe('foo');
       expect(node.hasAttribute('acceptCharset')).toBe(false);
@@ -501,9 +501,9 @@ describe('ReactDOMComponent', () => {
     });
 
     it('should apply React-specific aliases to SVG elements', () => {
-      var container = document.createElement('div');
+      const container = document.createElement('div');
       ReactDOM.render(<svg arabicForm="foo" />, container);
-      var node = container.firstChild;
+      const node = container.firstChild;
       // Test attribute initialization.
       expect(node.getAttribute('arabic-form')).toBe('foo');
       expect(node.hasAttribute('arabicForm')).toBe(false);
@@ -543,9 +543,9 @@ describe('ReactDOMComponent', () => {
     });
 
     it('should not apply React-specific aliases to custom elements', () => {
-      var container = document.createElement('div');
+      const container = document.createElement('div');
       ReactDOM.render(<some-custom-element arabicForm="foo" />, container);
-      var node = container.firstChild;
+      const node = container.firstChild;
       // Should not get transformed to arabic-form as SVG would be.
       expect(node.getAttribute('arabicForm')).toBe('foo');
       expect(node.hasAttribute('arabic-form')).toBe(false);

packages/react-dom/src/__tests__/validateDOMNesting-test.js

@@ -9,8 +9,8 @@
 
 'use strict';
 
-var React = require('react');
-var ReactDOM = require('react-dom');
+const React = require('react');
+const ReactDOM = require('react-dom');
 
 function normalizeCodeLocInfo(str) {
   return str && str.replace(/at .+?:\d+/g, 'at **');

packages/react-dom/src/events/forks/EventListener-www.js

@@ -7,7 +7,7 @@
  * @flow
  */
 
-var EventListenerWWW = require('EventListener');
+const EventListenerWWW = require('EventListener');
 
 import typeof * as EventListenerType from '../EventListener';
 import typeof * as EventListenerShimType from './EventListener-www';

scripts/babel/__tests__/transform-prevent-infinite-loops-test.js

@@ -4,6 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  */
+'use strict';
 
 describe('transform-prevent-infinite-loops', () => {
   // Note: instead of testing the transform by applying it,

scripts/eslint/es5Config.js

@@ -1,3 +1,12 @@
+/**
+ * Copyright (c) 2013-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+'use strict';
+
 const eslintrc = require('../../.eslintrc');
 
 const ERROR = 2;
@@ -6,13 +15,13 @@ module.exports = Object.assign({}, eslintrc, {
   parser: 'espree',
   parserOptions: {
     ecmaVersion: 2017,
-    sourceType: 'module',
+    sourceType: 'script',
     ecmaFeatures: {
-      jsx: true,
       experimentalObjectRestSpread: true,
     },
   },
   rules: Object.assign({}, eslintrc.rules, {
     'no-var': ERROR,
+    strict: ERROR,
   }),
 });

scripts/eslint/esNextConfig.js

@@ -0,0 +1,18 @@
+/**
+ * Copyright (c) 2013-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+'use strict';
+
+const eslintrc = require('../../.eslintrc');
+
+module.exports = Object.assign({}, eslintrc, {
+  parser: 'espree',
+  parserOptions: {
+    ecmaVersion: 5,
+    sourceType: 'script',
+  },
+});

scripts/eslint/es6Config.js scripts/eslint/eslintrc.node.jsscripts/eslint/es6Config.js renamed to scripts/eslint/eslintrc.node.js

@@ -0,0 +1,18 @@
+/**
+ * Copyright (c) 2013-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+'use strict';
+
+const eslintrc = require('../../.eslintrc');
+
+const ERROR = 2;
+
+module.exports = Object.assign({}, eslintrc, {
+  rules: Object.assign({}, eslintrc.rules, {
+    'no-var': ERROR,
+  }),
+});

scripts/eslint/eslintrc.npm.js

@@ -8,34 +8,34 @@
 'use strict';
 
 const CLIEngine = require('eslint').CLIEngine;
-const {es5Path, es6Path, esNextPath} = require('../shared/esPath');
+const {npmPath, nodePath, sourcePath} = require('../shared/esPath');
 
-const es5Options = {
-  configFile: `${__dirname}/es5Config.js`,
-  ignorePattern: [...es6Path, ...esNextPath],
+const npmOptions = {
+  configFile: `${__dirname}/eslintrc.npm.js`,
+  ignorePattern: [...nodePath, ...sourcePath],
 };
 
-const es6Options = {
-  configFile: `${__dirname}/es6Config.js`,
-  ignorePattern: [...es5Path, ...esNextPath],
+const nodeOptions = {
+  configFile: `${__dirname}/eslintrc.node.js`,
+  ignorePattern: [...npmPath, ...sourcePath],
 };
 
-const esNextOptions = {
-  configFile: `${__dirname}/esNextConfig.js`,
-  ignorePattern: [...es5Path, ...es6Path],
+const sourceOptions = {
+  configFile: `${__dirname}/eslintrc.source.js`,
+  ignorePattern: [...npmPath, ...nodePath],
 };
 
 module.exports = function lintOnFiles({ecmaVersion, filePatterns}) {
   let options;
   switch (ecmaVersion) {
     case '5':
-      options = es5Options;
+      options = npmOptions;
       break;
     case '6':
-      options = es6Options;
+      options = nodeOptions;
       break;
     case 'next':
-      options = esNextOptions;
+      options = sourceOptions;
       break;
     default:
       console.error('ecmaVersion only accpet value: "5", "6", "next"');