cleanup lints

Author: gnoff

packages/react-dom/src/__tests__/ReactDOMImageLoad-test.internal.js

@@ -15,7 +15,6 @@ let ReactCache;
 let ReactDOM;
 let Suspense;
 let originalCreateElement;
-let globalImgCache;
 let TextResource;
 let textResourceShouldFail;
 
@@ -65,12 +64,8 @@ function AsyncText(props) {
   }
 }
 
-function ImageLoader({src, useImageLoader, ref}) {
-  useImageLoader(src, ref);
-}
-
 function Img({src: maybeSrc, onLoad, useImageLoader, ref}) {
-  let src = maybeSrc || 'default';
+  const src = maybeSrc || 'default';
   Scheduler.unstable_yieldValue('Img ' + src);
   return <img src={src} onLoad={onLoad} />;
 }
@@ -97,12 +92,12 @@ describe.only('ReactDOMImageLoad', () => {
     Suspense = React.Suspense;
 
     onLoadSpy = jest.fn(reactEvent => {
-      let src = reactEvent.target.getAttribute('src');
+      const src = reactEvent.target.getAttribute('src');
       Scheduler.unstable_yieldValue('onLoadSpy [' + src + ']');
     });
 
     actualLoadSpy = jest.fn(nativeEvent => {
-      let src = nativeEvent.target.getAttribute('src');
+      const src = nativeEvent.target.getAttribute('src');
       Scheduler.unstable_yieldValue('actualLoadSpy [' + src + ']');
       nativeEvent.__originalDispatch = false;
     });
@@ -160,7 +155,7 @@ describe.only('ReactDOMImageLoad', () => {
 
     originalCreateElement = document.createElement;
     document.createElement = function createElement(tagName, options) {
-      let element = originalCreateElement.call(document, tagName, options);
+      const element = originalCreateElement.call(document, tagName, options);
       if (tagName === 'img') {
         element.addEventListener('load', actualLoadSpy);
         images.push(element);
@@ -203,7 +198,7 @@ describe.only('ReactDOMImageLoad', () => {
       'Img default',
       'Yield',
     ]);
-    let img = last(images);
+    const img = last(images);
     loadImage(img);
     expect(Scheduler).toHaveYielded([
       'actualLoadSpy [default]',
@@ -243,7 +238,7 @@ describe.only('ReactDOMImageLoad', () => {
       'last layout',
     ]);
     Scheduler.unstable_requestPaint();
-    let img = last(images);
+    const img = last(images);
     loadImage(img);
     expect(Scheduler).toHaveYielded([
       'actualLoadSpy [default]',
@@ -259,7 +254,7 @@ describe.only('ReactDOMImageLoad', () => {
     const root = ReactDOM.createRoot(container);
 
     function Base() {
-      let [src, setSrc] = React.useState('a');
+      const [src, setSrc] = React.useState('a');
       return (
         <PhaseMarkers>
           <Img src={src} onLoad={onLoadSpy} />
@@ -283,7 +278,7 @@ describe.only('ReactDOMImageLoad', () => {
       'Img a',
       'Yield',
     ]);
-    let img = last(images);
+    const img = last(images);
     loadImage(img);
     expect(Scheduler).toHaveYielded(['actualLoadSpy [a]']);
 
@@ -322,7 +317,7 @@ describe.only('ReactDOMImageLoad', () => {
       'last layout',
       'last passive',
     ]);
-    let img = last(images);
+    const img = last(images);
     loadImage(img);
     expect(Scheduler).toHaveYielded([
       'actualLoadSpy [default]',
@@ -336,7 +331,7 @@ describe.only('ReactDOMImageLoad', () => {
     const root = ReactDOM.createRoot(container);
 
     function ChildSuppressing({children}) {
-      let [showChildren, update] = React.useState(true);
+      const [showChildren, update] = React.useState(true);
       React.useLayoutEffect(() => {
         if (showChildren) {
           update(false);
@@ -362,7 +357,7 @@ describe.only('ReactDOMImageLoad', () => {
       'Img default',
       'Yield',
     ]);
-    let img = last(images);
+    const img = last(images);
     loadImage(img);
     expect(Scheduler).toHaveYielded(['actualLoadSpy [default]']);
     expect(Scheduler).toFlushAndYield([
@@ -385,7 +380,7 @@ describe.only('ReactDOMImageLoad', () => {
     const root = ReactDOM.createRoot(container);
 
     function Switch({children}) {
-      let [shouldShow, updateShow] = React.useState(true);
+      const [shouldShow, updateShow] = React.useState(true);
       return children(shouldShow, updateShow);
     }
 
@@ -424,7 +419,7 @@ describe.only('ReactDOMImageLoad', () => {
       'Img default',
       'Yield',
     ]);
-    let img = last(images);
+    const img = last(images);
     loadImage(img);
     expect(Scheduler).toHaveYielded(['actualLoadSpy [default]']);
     expect(Scheduler).toFlushAndYield([
@@ -447,7 +442,7 @@ describe.only('ReactDOMImageLoad', () => {
     expect(onLoadSpy).not.toHaveBeenCalled();
   });
 
-  xit('captures the load event if it happens in a suspended subtree and replays it between layout and passive effects on resumption', async function() {
+  fit('captures the load event if it happens in a suspended subtree and replays it between layout and passive effects on resumption', async function() {
     function SuspendingWithImage() {
       Scheduler.unstable_yieldValue('SuspendingWithImage');
       return (
@@ -514,8 +509,8 @@ describe.only('ReactDOMImageLoad', () => {
     let externalSetSrcAlt = null;
 
     function Base() {
-      let [src, setSrc] = React.useState(null);
-      let [srcAlt, setSrcAlt] = React.useState(null);
+      const [src, setSrc] = React.useState(null);
+      const [srcAlt, setSrcAlt] = React.useState(null);
       externalSetSrc = setSrc;
       externalSetSrcAlt = setSrcAlt;
       return srcAlt || src ? <YieldingWithImage src={srcAlt || src} /> : null;
@@ -578,6 +573,4 @@ describe.only('ReactDOMImageLoad', () => {
       'Committed',
     ]);
   });
-
-  it('load event twice on changing src when dom element is re-used, ensure only second load event is replayed', async function() {});
 });

packages/react-dom/src/client/ReactDOMHostConfig.js

@@ -438,8 +438,8 @@ export function commitMount(
           | HTMLInputElement
           | HTMLSelectElement
           | HTMLTextAreaElement).focus();
-        return;
       }
+      return;
     case 'img': {
       if ((newProps: any).src) {
         ((domElement: any): HTMLImageElement).src = ((domElement: any): HTMLImageElement).src;