Skip to content

Commit 61a26a9

Browse files
committed
Cancel finished view transitions Animations manually in fire-and-forget too (#32545)
Otherwise these can survive into the next View Transition and cause havoc to that transition. This was appearing as a flash in Safari in the fixture when going from A->B. This triggers a View Transition and at the same time the scroll position updates in an effect. That fires a scroll event which starts a gesture. This shouldn't really happen and the SwipeRecognizer should ideally ignore those but it's good to surface edge cases. That gesture is blocked on the View Transition finishing and then immediately after it starts a gesture View Transition. That gesture then picked up the former Animation from the previous transition which caused issues. This PR fixes that flash. DiffTrain build for [a8c2bbd](a8c2bbd)
1 parent a3e4ff9 commit 61a26a9

34 files changed

+928
-778
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
cc680065c33739cc4c8cd2e8a67312b0c16a6ccc
1+
696950aa69e3f2ef0d720c82705e02b532904d70
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
cc680065c33739cc4c8cd2e8a67312b0c16a6ccc
1+
696950aa69e3f2ef0d720c82705e02b532904d70

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1532,7 +1532,7 @@ __DEV__ &&
15321532
exports.useTransition = function () {
15331533
return resolveDispatcher().useTransition();
15341534
};
1535-
exports.version = "19.1.0-www-classic-cc680065-20250307";
1535+
exports.version = "19.1.0-www-classic-a8c2bbda-20250310";
15361536
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15371537
"function" ===
15381538
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1532,7 +1532,7 @@ __DEV__ &&
15321532
exports.useTransition = function () {
15331533
return resolveDispatcher().useTransition();
15341534
};
1535-
exports.version = "19.1.0-www-modern-cc680065-20250307";
1535+
exports.version = "19.1.0-www-modern-a8c2bbda-20250310";
15361536
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15371537
"function" ===
15381538
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -641,4 +641,4 @@ exports.useSyncExternalStore = function (
641641
exports.useTransition = function () {
642642
return ReactSharedInternals.H.useTransition();
643643
};
644-
exports.version = "19.1.0-www-classic-cc680065-20250307";
644+
exports.version = "19.1.0-www-classic-a8c2bbda-20250310";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -641,4 +641,4 @@ exports.useSyncExternalStore = function (
641641
exports.useTransition = function () {
642642
return ReactSharedInternals.H.useTransition();
643643
};
644-
exports.version = "19.1.0-www-modern-cc680065-20250307";
644+
exports.version = "19.1.0-www-modern-a8c2bbda-20250310";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ exports.useSyncExternalStore = function (
645645
exports.useTransition = function () {
646646
return ReactSharedInternals.H.useTransition();
647647
};
648-
exports.version = "19.1.0-www-classic-cc680065-20250307";
648+
exports.version = "19.1.0-www-classic-a8c2bbda-20250310";
649649
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
650650
"function" ===
651651
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ exports.useSyncExternalStore = function (
645645
exports.useTransition = function () {
646646
return ReactSharedInternals.H.useTransition();
647647
};
648-
exports.version = "19.1.0-www-modern-cc680065-20250307";
648+
exports.version = "19.1.0-www-modern-a8c2bbda-20250310";
649649
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
650650
"function" ===
651651
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18486,10 +18486,10 @@ __DEV__ &&
1848618486
(function () {
1848718487
var internals = {
1848818488
bundleType: 1,
18489-
version: "19.1.0-www-classic-cc680065-20250307",
18489+
version: "19.1.0-www-classic-a8c2bbda-20250310",
1849018490
rendererPackageName: "react-art",
1849118491
currentDispatcherRef: ReactSharedInternals,
18492-
reconcilerVersion: "19.1.0-www-classic-cc680065-20250307"
18492+
reconcilerVersion: "19.1.0-www-classic-a8c2bbda-20250310"
1849318493
};
1849418494
internals.overrideHookState = overrideHookState;
1849518495
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18523,7 +18523,7 @@ __DEV__ &&
1852318523
exports.Shape = Shape;
1852418524
exports.Surface = Surface;
1852518525
exports.Text = Text;
18526-
exports.version = "19.1.0-www-classic-cc680065-20250307";
18526+
exports.version = "19.1.0-www-classic-a8c2bbda-20250310";
1852718527
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1852818528
"function" ===
1852918529
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18258,10 +18258,10 @@ __DEV__ &&
1825818258
(function () {
1825918259
var internals = {
1826018260
bundleType: 1,
18261-
version: "19.1.0-www-modern-cc680065-20250307",
18261+
version: "19.1.0-www-modern-a8c2bbda-20250310",
1826218262
rendererPackageName: "react-art",
1826318263
currentDispatcherRef: ReactSharedInternals,
18264-
reconcilerVersion: "19.1.0-www-modern-cc680065-20250307"
18264+
reconcilerVersion: "19.1.0-www-modern-a8c2bbda-20250310"
1826518265
};
1826618266
internals.overrideHookState = overrideHookState;
1826718267
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18295,7 +18295,7 @@ __DEV__ &&
1829518295
exports.Shape = Shape;
1829618296
exports.Surface = Surface;
1829718297
exports.Text = Text;
18298-
exports.version = "19.1.0-www-modern-cc680065-20250307";
18298+
exports.version = "19.1.0-www-modern-a8c2bbda-20250310";
1829918299
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1830018300
"function" ===
1830118301
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)