Skip to content

Commit 558bd86

Browse files
committed
Add todo
1 parent 20d8a04 commit 558bd86

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

packages/react-reconciler/src/ReactFiberCommitWork.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2420,6 +2420,8 @@ export function detachOffscreenInstance(instance: OffscreenInstance): void {
24202420
return;
24212421
}
24222422

2423+
// TODO: There is an opportunity to optimise this by not entering commit phase
2424+
// and unmounting effects directly.
24232425
const root = enqueueConcurrentRenderForLane(fiber, SyncLane);
24242426
if (root !== null) {
24252427
instance._pendingVisibility |= OffscreenDetached;

0 commit comments

Comments
 (0)