File tree Expand file tree Collapse file tree 2 files changed +14
-10
lines changed
packages/react-reconciler/src Expand file tree Collapse file tree 2 files changed +14
-10
lines changed Original file line number Diff line number Diff line change @@ -2005,6 +2005,13 @@ function commitPassiveUnmountEffectsInsideOfDeletedTree_begin(
2005
2005
) {
2006
2006
while ( nextEffect !== null ) {
2007
2007
const fiber = nextEffect ;
2008
+
2009
+ // Deletion effects fire in parent -> child order
2010
+ // TODO: Check if fiber has a PassiveStatic flag
2011
+ setCurrentDebugFiberInDEV ( fiber ) ;
2012
+ commitPassiveUnmountInsideDeletedTreeOnFiber ( fiber ) ;
2013
+ resetCurrentDebugFiberInDEV ( ) ;
2014
+
2008
2015
const child = fiber . child ;
2009
2016
// TODO: Only traverse subtree if it has a PassiveStatic flag
2010
2017
if ( child !== null ) {
@@ -2023,11 +2030,6 @@ function commitPassiveUnmountEffectsInsideOfDeletedTree_complete(
2023
2030
) {
2024
2031
while ( nextEffect !== null ) {
2025
2032
const fiber = nextEffect ;
2026
- // TODO: Check if fiber has a PassiveStatic flag
2027
- setCurrentDebugFiberInDEV ( fiber ) ;
2028
- commitPassiveUnmountInsideDeletedTreeOnFiber ( fiber ) ;
2029
- resetCurrentDebugFiberInDEV ( ) ;
2030
-
2031
2033
if ( fiber === deletedSubtreeRoot ) {
2032
2034
nextEffect = null ;
2033
2035
return ;
Original file line number Diff line number Diff line change @@ -2005,6 +2005,13 @@ function commitPassiveUnmountEffectsInsideOfDeletedTree_begin(
2005
2005
) {
2006
2006
while ( nextEffect !== null ) {
2007
2007
const fiber = nextEffect ;
2008
+
2009
+ // Deletion effects fire in parent -> child order
2010
+ // TODO: Check if fiber has a PassiveStatic flag
2011
+ setCurrentDebugFiberInDEV ( fiber ) ;
2012
+ commitPassiveUnmountInsideDeletedTreeOnFiber ( fiber ) ;
2013
+ resetCurrentDebugFiberInDEV ( ) ;
2014
+
2008
2015
const child = fiber . child ;
2009
2016
// TODO: Only traverse subtree if it has a PassiveStatic flag
2010
2017
if ( child !== null ) {
@@ -2023,11 +2030,6 @@ function commitPassiveUnmountEffectsInsideOfDeletedTree_complete(
2023
2030
) {
2024
2031
while ( nextEffect !== null ) {
2025
2032
const fiber = nextEffect ;
2026
- // TODO: Check if fiber has a PassiveStatic flag
2027
- setCurrentDebugFiberInDEV ( fiber ) ;
2028
- commitPassiveUnmountInsideDeletedTreeOnFiber ( fiber ) ;
2029
- resetCurrentDebugFiberInDEV ( ) ;
2030
-
2031
2033
if ( fiber === deletedSubtreeRoot ) {
2032
2034
nextEffect = null ;
2033
2035
return ;
You can’t perform that action at this time.
0 commit comments