Skip to content

Commit 48616e5

Browse files
raphamorimgaearon
raphamorim
authored and
gaearon
committed
react-dom: convert packages/react-dom/src/__tests__ (#11776)
1 parent 1637b43 commit 48616e5

File tree

58 files changed

+1591
-1579
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+1591
-1579
lines changed

‎packages/react-dom/src/__tests__/CSSPropertyOperations-test.js

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -9,76 +9,76 @@
99

1010
'use strict';
1111

12-
var React = require('react');
13-
var ReactDOM = require('react-dom');
14-
var ReactDOMServer = require('react-dom/server');
12+
const React = require('react');
13+
const ReactDOM = require('react-dom');
14+
const ReactDOMServer = require('react-dom/server');
1515

1616
function normalizeCodeLocInfo(str) {
1717
return str && str.replace(/at .+?:\d+/g, 'at **');
1818
}
1919

2020
describe('CSSPropertyOperations', () => {
2121
it('should automatically append `px` to relevant styles', () => {
22-
var styles = {
22+
const styles = {
2323
left: 0,
2424
margin: 16,
2525
opacity: 0.5,
2626
padding: '4px',
2727
};
28-
var div = <div style={styles} />;
29-
var html = ReactDOMServer.renderToString(div);
28+
const div = <div style={styles} />;
29+
const html = ReactDOMServer.renderToString(div);
3030
expect(html).toContain('"left:0;margin:16px;opacity:0.5;padding:4px"');
3131
});
3232

3333
it('should trim values', () => {
34-
var styles = {
34+
const styles = {
3535
left: '16 ',
3636
opacity: 0.5,
3737
right: ' 4 ',
3838
};
39-
var div = <div style={styles} />;
40-
var html = ReactDOMServer.renderToString(div);
39+
const div = <div style={styles} />;
40+
const html = ReactDOMServer.renderToString(div);
4141
expect(html).toContain('"left:16;opacity:0.5;right:4"');
4242
});
4343

4444
it('should not append `px` to styles that might need a number', () => {
45-
var styles = {
45+
const styles = {
4646
flex: 0,
4747
opacity: 0.5,
4848
};
49-
var div = <div style={styles} />;
50-
var html = ReactDOMServer.renderToString(div);
49+
const div = <div style={styles} />;
50+
const html = ReactDOMServer.renderToString(div);
5151
expect(html).toContain('"flex:0;opacity:0.5"');
5252
});
5353

5454
it('should create vendor-prefixed markup correctly', () => {
55-
var styles = {
55+
const styles = {
5656
msTransition: 'none',
5757
MozTransition: 'none',
5858
};
59-
var div = <div style={styles} />;
60-
var html = ReactDOMServer.renderToString(div);
59+
const div = <div style={styles} />;
60+
const html = ReactDOMServer.renderToString(div);
6161
expect(html).toContain('"-ms-transition:none;-moz-transition:none"');
6262
});
6363

6464
it('should set style attribute when styles exist', () => {
65-
var styles = {
65+
const styles = {
6666
backgroundColor: '#000',
6767
display: 'none',
6868
};
69-
var div = <div style={styles} />;
70-
var root = document.createElement('div');
69+
let div = <div style={styles} />;
70+
const root = document.createElement('div');
7171
div = ReactDOM.render(div, root);
7272
expect(/style=".*"/.test(root.innerHTML)).toBe(true);
7373
});
7474

7575
it('should not set style attribute when no styles exist', () => {
76-
var styles = {
76+
const styles = {
7777
backgroundColor: null,
7878
display: null,
7979
};
80-
var div = <div style={styles} />;
81-
var html = ReactDOMServer.renderToString(div);
80+
const div = <div style={styles} />;
81+
const html = ReactDOMServer.renderToString(div);
8282
expect(/style=/.test(html)).toBe(false);
8383
});
8484

@@ -92,7 +92,7 @@ describe('CSSPropertyOperations', () => {
9292
}
9393

9494
spyOnDev(console, 'error');
95-
var root = document.createElement('div');
95+
const root = document.createElement('div');
9696
ReactDOM.render(<Comp />, root);
9797
if (__DEV__) {
9898
expect(console.error.calls.count()).toBe(1);
@@ -114,11 +114,11 @@ describe('CSSPropertyOperations', () => {
114114
}
115115

116116
spyOnDev(console, 'error');
117-
var styles = {
117+
const styles = {
118118
'-ms-transform': 'translate3d(0, 0, 0)',
119119
'-webkit-transform': 'translate3d(0, 0, 0)',
120120
};
121-
var root = document.createElement('div');
121+
const root = document.createElement('div');
122122
ReactDOM.render(<Comp />, root);
123123
ReactDOM.render(<Comp style={styles} />, root);
124124

@@ -155,7 +155,7 @@ describe('CSSPropertyOperations', () => {
155155
}
156156

157157
spyOnDev(console, 'error');
158-
var root = document.createElement('div');
158+
const root = document.createElement('div');
159159
ReactDOM.render(<Comp />, root);
160160
if (__DEV__) {
161161
// msTransform is correct already and shouldn't warn
@@ -194,7 +194,7 @@ describe('CSSPropertyOperations', () => {
194194
}
195195

196196
spyOnDev(console, 'error');
197-
var root = document.createElement('div');
197+
const root = document.createElement('div');
198198
ReactDOM.render(<Comp />, root);
199199
if (__DEV__) {
200200
expect(console.error.calls.count()).toBe(2);
@@ -223,7 +223,7 @@ describe('CSSPropertyOperations', () => {
223223
}
224224

225225
spyOnDev(console, 'error');
226-
var root = document.createElement('div');
226+
const root = document.createElement('div');
227227
ReactDOM.render(<Comp />, root);
228228

229229
if (__DEV__) {
@@ -243,7 +243,7 @@ describe('CSSPropertyOperations', () => {
243243
}
244244
}
245245

246-
var root = document.createElement('div');
246+
const root = document.createElement('div');
247247
ReactDOM.render(<Comp />, root);
248248
});
249249

@@ -257,7 +257,7 @@ describe('CSSPropertyOperations', () => {
257257
}
258258

259259
spyOnDev(console, 'error');
260-
var root = document.createElement('div');
260+
const root = document.createElement('div');
261261
ReactDOM.render(<Comp />, root);
262262

263263
if (__DEV__) {
@@ -277,7 +277,7 @@ describe('CSSPropertyOperations', () => {
277277
}
278278
}
279279

280-
var root = document.createElement('div');
280+
const root = document.createElement('div');
281281
ReactDOM.render(<Comp />, root);
282282

283283
expect(root.children[0].style.Foo).toEqual('5');

‎packages/react-dom/src/__tests__/DOMPropertyOperations-test.js

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
'use strict';
1111

1212
describe('DOMPropertyOperations', () => {
13-
var React;
14-
var ReactDOM;
13+
let React;
14+
let ReactDOM;
1515

1616
beforeEach(() => {
1717
jest.resetModules();
@@ -21,20 +21,20 @@ describe('DOMPropertyOperations', () => {
2121

2222
describe('setValueForProperty', () => {
2323
it('should set values as properties by default', () => {
24-
var container = document.createElement('div');
24+
const container = document.createElement('div');
2525
ReactDOM.render(<div title="Tip!" />, container);
2626
expect(container.firstChild.title).toBe('Tip!');
2727
});
2828

2929
it('should set values as attributes if necessary', () => {
30-
var container = document.createElement('div');
30+
const container = document.createElement('div');
3131
ReactDOM.render(<div role="#" />, container);
3232
expect(container.firstChild.getAttribute('role')).toBe('#');
3333
expect(container.firstChild.role).toBeUndefined();
3434
});
3535

3636
it('should set values as namespace attributes if necessary', () => {
37-
var container = document.createElement('svg');
37+
const container = document.createElement('svg');
3838
ReactDOM.render(<image xlinkHref="about:blank" />, container);
3939
expect(
4040
container.firstChild.getAttributeNS(
@@ -45,7 +45,7 @@ describe('DOMPropertyOperations', () => {
4545
});
4646

4747
it('should set values as boolean properties', () => {
48-
var container = document.createElement('div');
48+
const container = document.createElement('div');
4949
ReactDOM.render(<div disabled="disabled" />, container);
5050
expect(container.firstChild.getAttribute('disabled')).toBe('');
5151
ReactDOM.render(<div disabled={true} />, container);
@@ -63,40 +63,40 @@ describe('DOMPropertyOperations', () => {
6363
it('should convert attribute values to string first', () => {
6464
// Browsers default to this behavior, but some test environments do not.
6565
// This ensures that we have consistent behavior.
66-
var obj = {
66+
const obj = {
6767
toString: function() {
6868
return 'css-class';
6969
},
7070
};
7171

72-
var container = document.createElement('div');
72+
const container = document.createElement('div');
7373
ReactDOM.render(<div className={obj} />, container);
7474
expect(container.firstChild.getAttribute('class')).toBe('css-class');
7575
});
7676

7777
it('should not remove empty attributes for special properties', () => {
78-
var container = document.createElement('div');
78+
const container = document.createElement('div');
7979
ReactDOM.render(<input value="" />, container);
8080
expect(container.firstChild.getAttribute('value')).toBe('');
8181
expect(container.firstChild.value).toBe('');
8282
});
8383

8484
it('should remove for falsey boolean properties', () => {
85-
var container = document.createElement('div');
85+
const container = document.createElement('div');
8686
ReactDOM.render(<div allowFullScreen={false} />, container);
8787
expect(container.firstChild.hasAttribute('allowFullScreen')).toBe(false);
8888
});
8989

9090
it('should remove when setting custom attr to null', () => {
91-
var container = document.createElement('div');
91+
const container = document.createElement('div');
9292
ReactDOM.render(<div data-foo="bar" />, container);
9393
expect(container.firstChild.hasAttribute('data-foo')).toBe(true);
9494
ReactDOM.render(<div data-foo={null} />, container);
9595
expect(container.firstChild.hasAttribute('data-foo')).toBe(false);
9696
});
9797

9898
it('should set className to empty string instead of null', () => {
99-
var container = document.createElement('div');
99+
const container = document.createElement('div');
100100
ReactDOM.render(<div className="selected" />, container);
101101
expect(container.firstChild.className).toBe('selected');
102102
ReactDOM.render(<div className={null} />, container);
@@ -107,7 +107,7 @@ describe('DOMPropertyOperations', () => {
107107
});
108108

109109
it('should remove property properly for boolean properties', () => {
110-
var container = document.createElement('div');
110+
const container = document.createElement('div');
111111
ReactDOM.render(<div hidden={true} />, container);
112112
expect(container.firstChild.hasAttribute('hidden')).toBe(true);
113113
ReactDOM.render(<div hidden={false} />, container);
@@ -117,7 +117,7 @@ describe('DOMPropertyOperations', () => {
117117

118118
describe('value mutation method', function() {
119119
it('should update an empty attribute to zero', function() {
120-
var container = document.createElement('div');
120+
const container = document.createElement('div');
121121
ReactDOM.render(
122122
<input type="radio" value="" onChange={function() {}} />,
123123
container,
@@ -131,7 +131,7 @@ describe('DOMPropertyOperations', () => {
131131
});
132132

133133
it('should always assign the value attribute for non-inputs', function() {
134-
var container = document.createElement('div');
134+
const container = document.createElement('div');
135135
ReactDOM.render(<progress />, container);
136136
spyOnDevAndProd(container.firstChild, 'setAttribute');
137137
ReactDOM.render(<progress value={30} />, container);
@@ -142,15 +142,15 @@ describe('DOMPropertyOperations', () => {
142142

143143
describe('deleteValueForProperty', () => {
144144
it('should remove attributes for normal properties', () => {
145-
var container = document.createElement('div');
145+
const container = document.createElement('div');
146146
ReactDOM.render(<div title="foo" />, container);
147147
expect(container.firstChild.getAttribute('title')).toBe('foo');
148148
ReactDOM.render(<div />, container);
149149
expect(container.firstChild.getAttribute('title')).toBe(null);
150150
});
151151

152152
it('should not remove attributes for special properties', () => {
153-
var container = document.createElement('div');
153+
const container = document.createElement('div');
154154
spyOnDev(console, 'error');
155155
ReactDOM.render(
156156
<input type="text" value="foo" onChange={function() {}} />,

‎packages/react-dom/src/__tests__/EventPluginHub-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
jest.mock('../events/isEventSupported');
1313

1414
describe('EventPluginHub', () => {
15-
var React;
16-
var ReactTestUtils;
15+
let React;
16+
let ReactTestUtils;
1717

1818
beforeEach(() => {
1919
jest.resetModules();
@@ -23,7 +23,7 @@ describe('EventPluginHub', () => {
2323

2424
it('should prevent non-function listeners, at dispatch', () => {
2525
spyOnDev(console, 'error');
26-
var node = ReactTestUtils.renderIntoDocument(
26+
const node = ReactTestUtils.renderIntoDocument(
2727
<div onClick="not a function" />,
2828
);
2929
expect(function() {
@@ -40,7 +40,7 @@ describe('EventPluginHub', () => {
4040
});
4141

4242
it('should not prevent null listeners, at dispatch', () => {
43-
var node = ReactTestUtils.renderIntoDocument(<div onClick={null} />);
43+
const node = ReactTestUtils.renderIntoDocument(<div onClick={null} />);
4444
expect(function() {
4545
ReactTestUtils.SimulateNative.click(node);
4646
}).not.toThrow();

0 commit comments

Comments
 (0)