Skip to content

Commit 3e44980

Browse files
author
Clement Hoang
committed
Remove extra tests for Fragment
1 parent 5284c01 commit 3e44980

File tree

3 files changed

+14
-100
lines changed

3 files changed

+14
-100
lines changed

src/isomorphic/modern/class/__tests__/ReactFragment-test.js

Lines changed: 8 additions & 89 deletions
Original file line numberDiff line numberDiff line change
@@ -10,87 +10,17 @@
1010
*/
1111
'use strict';
1212

13-
let React;
14-
let ReactDOM;
15-
let createRenderer;
16-
let ReactTestRenderer;
17-
let ReactNoop;
18-
let ReactNative;
19-
let UIManager;
20-
let createReactNativeComponentClass;
21-
let ReactDOMFeatureFlags = require('ReactDOMFeatureFlags');
22-
let element;
13+
const React = require('React');
14+
const ReactNoop = require('react-noop-renderer');
2315

24-
describe('ReactFragment', () => {
25-
beforeEach(() => {
26-
jest.resetModules();
27-
28-
React = require('react');
29-
30-
element = (
31-
<React.Fragment>
32-
hello <span>world</span>
33-
</React.Fragment>
34-
);
35-
});
36-
37-
it('should render via native renderer', () => {
38-
ReactNative = require('react-native');
39-
UIManager = require('UIManager');
40-
createReactNativeComponentClass = require('createReactNativeComponentClass');
41-
42-
const View = createReactNativeComponentClass('View', () => ({
43-
validAttributes: {foo: true},
44-
uiViewClassName: 'View',
45-
}));
46-
const Text = createReactNativeComponentClass('Text', () => ({
47-
validAttributes: {foo: true},
48-
uiViewClassName: 'Text',
49-
}));
50-
51-
ReactNative.render(
52-
<View>
53-
<React.Fragment>
54-
<Text foo="a">1</Text>
55-
<Text foo="b">2</Text>
56-
</React.Fragment>
57-
</View>,
58-
11,
59-
);
60-
61-
expect(UIManager.__dumpHierarchyForJestTestsOnly()).toMatchSnapshot();
62-
});
63-
64-
it('should render via shallow renderer', () => {
65-
createRenderer = require('react-test-renderer/shallow').createRenderer;
66-
67-
const shallowRenderer = createRenderer();
68-
shallowRenderer.render(element);
69-
70-
expect(shallowRenderer.getRenderOutput()).toEqual([
71-
'hello ',
72-
<span>world</span>,
73-
]);
74-
});
75-
76-
it('should render via test renderer', () => {
77-
ReactTestRenderer = require('react-test-renderer');
78-
79-
const renderer = ReactTestRenderer.create(element);
80-
81-
expect(renderer.toJSON()).toEqual([
82-
'hello ',
83-
{
84-
type: 'span',
85-
props: {},
86-
children: ['world'],
87-
},
88-
]);
89-
});
16+
const element = (
17+
<React.Fragment>
18+
hello <span>world</span>
19+
</React.Fragment>
20+
);
9021

22+
describe('ReactFragment', () => {
9123
it('should render via noop renderer', () => {
92-
ReactNoop = require('react-noop-renderer');
93-
9424
ReactNoop.render(element);
9525
ReactNoop.flush();
9626

@@ -99,15 +29,4 @@ describe('ReactFragment', () => {
9929
{type: 'span', children: [], prop: undefined},
10030
]);
10131
});
102-
103-
if (ReactDOMFeatureFlags.useFiber) {
104-
it('should render via ReactDOM', () => {
105-
ReactDOM = require('react-dom');
106-
107-
const container = document.createElement('div');
108-
ReactDOM.render(element, container);
109-
110-
expect(container.innerHTML).toEqual('hello <span>world</span>');
111-
});
112-
}
11332
});

src/isomorphic/modern/class/__tests__/__snapshots__/ReactFragment-test.js.snap

Lines changed: 0 additions & 10 deletions
This file was deleted.

src/isomorphic/modern/element/__tests__/ReactJSXElementValidator-test.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,12 @@ describe('ReactJSXElementValidator', () => {
179179
it('does not warn when the element is directly as children', () => {
180180
spyOn(console, 'error');
181181

182-
void <Component><Component /><Component /></Component>;
182+
void (
183+
<Component>
184+
<Component />
185+
<Component />
186+
</Component>
187+
);
183188

184189
expectDev(console.error.calls.count()).toBe(0);
185190
});

0 commit comments

Comments
 (0)