Skip to content

Commit 214868d

Browse files
hoxyqhoxyq
committed
fix[ReactDebugHooks/find-primitive-index]: remove some assumptions (#29652)
Partially reverts #28593. While rolling out RDT 5.2.0, I've observed some issues on React Native side: hooks inspection for some complex hook trees, like in AnimatedView, were broken. After some debugging, I've noticed a difference between what is in frame's source. The difference is in the top-most frame, where with V8 it will correctly pick up the `Type` as `Proxy` in `hookStack`, but for Hermes it will be `Object`. This means that for React Native this top most frame is skipped, since sources are identical. Here I am reverting back to the previous logic, where we check each frame if its a part of the wrapper, but also updated `isReactWrapper` function to have an explicit case for `useFormStatus` support. DiffTrain build for commit fb61a1b.
1 parent a889374 commit 214868d

File tree

13 files changed

+35
-35
lines changed

13 files changed

+35
-35
lines changed

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<367c9327dcb04e3bfe28018853017027>>
10+
* @generated SignedSource<<7ca4155a78e484bb791befb0a0483562>>
1111
*/
1212

1313
'use strict';
@@ -23471,7 +23471,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2347123471
return root;
2347223472
}
2347323473

23474-
var ReactVersion = '19.0.0-rc-5bd4031226-20240530';
23474+
var ReactVersion = '19.0.0-rc-fb61a1b515-20240530';
2347523475

2347623476
/*
2347723477
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c59e1f648d055156cb5c653b5cb5e8f3>>
10+
* @generated SignedSource<<3467ef5cc029c44f026f965d523ec535>>
1111
*/
1212

1313
"use strict";
@@ -9298,7 +9298,7 @@ var devToolsConfig$jscomp$inline_1047 = {
92989298
throw Error("TestRenderer does not support findFiberByHostInstance()");
92999299
},
93009300
bundleType: 0,
9301-
version: "19.0.0-rc-5bd4031226-20240530",
9301+
version: "19.0.0-rc-fb61a1b515-20240530",
93029302
rendererPackageName: "react-test-renderer"
93039303
};
93049304
var internals$jscomp$inline_1234 = {
@@ -9329,7 +9329,7 @@ var internals$jscomp$inline_1234 = {
93299329
scheduleRoot: null,
93309330
setRefreshHandler: null,
93319331
getCurrentFiber: null,
9332-
reconcilerVersion: "19.0.0-rc-5bd4031226-20240530"
9332+
reconcilerVersion: "19.0.0-rc-fb61a1b515-20240530"
93339333
};
93349334
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
93359335
var hook$jscomp$inline_1235 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<b9e44a6e588f26082b700ae7ee00b4d6>>
10+
* @generated SignedSource<<dcdf0ff67842ef74c5e2d1b33aa75828>>
1111
*/
1212

1313
"use strict";
@@ -9920,7 +9920,7 @@ var devToolsConfig$jscomp$inline_1130 = {
99209920
throw Error("TestRenderer does not support findFiberByHostInstance()");
99219921
},
99229922
bundleType: 0,
9923-
version: "19.0.0-rc-5bd4031226-20240530",
9923+
version: "19.0.0-rc-fb61a1b515-20240530",
99249924
rendererPackageName: "react-test-renderer"
99259925
};
99269926
(function (internals) {
@@ -9964,7 +9964,7 @@ var devToolsConfig$jscomp$inline_1130 = {
99649964
scheduleRoot: null,
99659965
setRefreshHandler: null,
99669966
getCurrentFiber: null,
9967-
reconcilerVersion: "19.0.0-rc-5bd4031226-20240530"
9967+
reconcilerVersion: "19.0.0-rc-fb61a1b515-20240530"
99689968
});
99699969
exports._Scheduler = Scheduler;
99709970
exports.act = act;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<3418fd00fe2b53485f207d00155bc6b3>>
10+
* @generated SignedSource<<236832470786fa8d630f95ea59053100>>
1111
*/
1212

1313
'use strict';
@@ -24,7 +24,7 @@ if (
2424
}
2525
var dynamicFlagsUntyped = require('ReactNativeInternalFeatureFlags');
2626

27-
var ReactVersion = '19.0.0-rc-5bd4031226-20240530';
27+
var ReactVersion = '19.0.0-rc-fb61a1b515-20240530';
2828

2929
// Re-export dynamic flags from the internal module.
3030
var dynamicFlags = dynamicFlagsUntyped; // We destructure each value before re-exporting to avoid a dynamic look-up on

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<b6fbdccb3bf217f6f2c5fed4e0638b31>>
10+
* @generated SignedSource<<0ad7d99d0ddc3869ed760873fb4a1782>>
1111
*/
1212

1313
"use strict";
@@ -604,4 +604,4 @@ exports.useSyncExternalStore = function (
604604
exports.useTransition = function () {
605605
return ReactSharedInternals.H.useTransition();
606606
};
607-
exports.version = "19.0.0-rc-5bd4031226-20240530";
607+
exports.version = "19.0.0-rc-fb61a1b515-20240530";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<71b4749bcbc89ff9b3f9ce7b74843237>>
10+
* @generated SignedSource<<e486bd0359a6cb764eff1d066bebd329>>
1111
*/
1212

1313
"use strict";
@@ -608,7 +608,7 @@ exports.useSyncExternalStore = function (
608608
exports.useTransition = function () {
609609
return ReactSharedInternals.H.useTransition();
610610
};
611-
exports.version = "19.0.0-rc-5bd4031226-20240530";
611+
exports.version = "19.0.0-rc-fb61a1b515-20240530";
612612
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
613613
"function" ===
614614
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
5bd403122645ef0f0924ac5466f56e670a8f5b8d
1+
fb61a1b515c5ea0e31b0dac19184454a79c4baf1

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<78fe1eefa98ef7ce9f3aebf663a4466b>>
10+
* @generated SignedSource<<995c3dc1c310eccb6e0c62c1d4d635a7>>
1111
*/
1212

1313
'use strict';
@@ -26206,7 +26206,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2620626206
return root;
2620726207
}
2620826208

26209-
var ReactVersion = '19.0.0-rc-5bd4031226-20240530';
26209+
var ReactVersion = '19.0.0-rc-fb61a1b515-20240530';
2621026210

2621126211
/*
2621226212
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c40039fc034f320dbb7945da452feee1>>
10+
* @generated SignedSource<<845d34a6fb2bdf695a5050c565c6b6d8>>
1111
*/
1212

1313
"use strict";
@@ -10551,7 +10551,7 @@ var roots = new Map(),
1055110551
devToolsConfig$jscomp$inline_1124 = {
1055210552
findFiberByHostInstance: getInstanceFromNode,
1055310553
bundleType: 0,
10554-
version: "19.0.0-rc-5bd4031226-20240530",
10554+
version: "19.0.0-rc-fb61a1b515-20240530",
1055510555
rendererPackageName: "react-native-renderer",
1055610556
rendererConfig: {
1055710557
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10594,7 +10594,7 @@ var internals$jscomp$inline_1350 = {
1059410594
scheduleRoot: null,
1059510595
setRefreshHandler: null,
1059610596
getCurrentFiber: null,
10597-
reconcilerVersion: "19.0.0-rc-5bd4031226-20240530"
10597+
reconcilerVersion: "19.0.0-rc-fb61a1b515-20240530"
1059810598
};
1059910599
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1060010600
var hook$jscomp$inline_1351 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<687caccb927bc1400fc4b3a52c018710>>
10+
* @generated SignedSource<<e6d8bc91c13c8cda3989052069e1ea8f>>
1111
*/
1212

1313
"use strict";
@@ -11257,7 +11257,7 @@ var roots = new Map(),
1125711257
devToolsConfig$jscomp$inline_1205 = {
1125811258
findFiberByHostInstance: getInstanceFromNode,
1125911259
bundleType: 0,
11260-
version: "19.0.0-rc-5bd4031226-20240530",
11260+
version: "19.0.0-rc-fb61a1b515-20240530",
1126111261
rendererPackageName: "react-native-renderer",
1126211262
rendererConfig: {
1126311263
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11313,7 +11313,7 @@ var roots = new Map(),
1131311313
scheduleRoot: null,
1131411314
setRefreshHandler: null,
1131511315
getCurrentFiber: null,
11316-
reconcilerVersion: "19.0.0-rc-5bd4031226-20240530"
11316+
reconcilerVersion: "19.0.0-rc-fb61a1b515-20240530"
1131711317
});
1131811318
exports.createPortal = function (children, containerTag) {
1131911319
return createPortal$1(

0 commit comments

Comments
 (0)