Split out Edge and Node implementations of the Flight Client (#26187)

sebmarkbage · sebmarkbage · commit 186e383fbcaa · 2023-02-21T18:23:17.000Z
This splits out the Edge and Node implementations of Flight Client into their own implementations. The Node implementation now takes a Node Stream as input. I removed the bundler config from the Browser variant because you're never supposed to use that in the browser since it's only for SSR. Similarly, it's required on the server. This also enables generating a SSR manifest from the Webpack plugin. This is necessary for SSR so that you can reverse look up what a client module is called on the server. I also removed the option to pass a callServer from the server. We might want to add it back in the future but basically, we don't recommend calling Server Functions from render for initial render because if that happened client-side it would be a client-side waterfall. If it's never called in initial render, then it also shouldn't ever happen during SSR. This might be considered too restrictive. ~This also compiles the unbundled packages as ESM. This isn't strictly necessary because we only need access to dynamic import to load the modules but we don't have any other build options that leave `import(...)` intact, and seems appropriate that this would also be an ESM module.~ Went with `import(...)` in CJS instead. DiffTrain build for commit 60144a0.
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-70b0bbda767ed016925889e8952b10f49921c0cf
+60144a04da7970e30266f591dbcd67afe1097e41
diff --git a/compiled/facebook-www/REVISION_TRANSFORMS b/compiled/facebook-www/REVISION_TRANSFORMS
@@ -1 +1 @@
-70b0bbda767ed016925889e8952b10f49921c0cf
+60144a04da7970e30266f591dbcd67afe1097e41
diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js
@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
 
 // ATTENTION
 // When adding new symbols to this file,
diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js
@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
 
 // ATTENTION
 // When adding new symbols to this file,
diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js
@@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-70b0bbda7-20230221";
+exports.version = "18.3.0-www-classic-60144a04d-20230221";
diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js
@@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-70b0bbda7-20230221";
+exports.version = "18.3.0-www-modern-60144a04d-20230221";
diff --git a/compiled/facebook-www/React-profiling.classic.js b/compiled/facebook-www/React-profiling.classic.js
@@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-70b0bbda7-20230221";
+exports.version = "18.3.0-www-classic-60144a04d-20230221";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (
diff --git a/compiled/facebook-www/React-profiling.modern.js b/compiled/facebook-www/React-profiling.modern.js
@@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-70b0bbda7-20230221";
+exports.version = "18.3.0-www-modern-60144a04d-20230221";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (
diff --git a/compiled/facebook-www/ReactART-dev.classic.js b/compiled/facebook-www/ReactART-dev.classic.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;
diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;
diff --git a/compiled/facebook-www/ReactART-prod.classic.js b/compiled/facebook-www/ReactART-prod.classic.js
@@ -9800,7 +9800,7 @@ var slice = Array.prototype.slice,
       return null;
     },
     bundleType: 0,
-    version: "18.3.0-www-classic-70b0bbda7-20230221",
+    version: "18.3.0-www-classic-60144a04d-20230221",
     rendererPackageName: "react-art"
   };
 var internals$jscomp$inline_1301 = {
@@ -9831,7 +9831,7 @@ var internals$jscomp$inline_1301 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
+  reconcilerVersion: "18.3.0-next-60144a04d-20230221"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1302 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
diff --git a/compiled/facebook-www/ReactART-prod.modern.js b/compiled/facebook-www/ReactART-prod.modern.js
@@ -9465,7 +9465,7 @@ var slice = Array.prototype.slice,
       return null;
     },
     bundleType: 0,
-    version: "18.3.0-www-modern-70b0bbda7-20230221",
+    version: "18.3.0-www-modern-60144a04d-20230221",
     rendererPackageName: "react-art"
   };
 var internals$jscomp$inline_1281 = {
@@ -9496,7 +9496,7 @@ var internals$jscomp$inline_1281 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
+  reconcilerVersion: "18.3.0-next-60144a04d-20230221"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1282 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js
@@ -41996,7 +41996,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
 
 function createPortal$1(
   children,
diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js
@@ -41600,7 +41600,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
 
 function createPortal$1(
   children,
diff --git a/compiled/facebook-www/ReactDOM-prod.classic.js b/compiled/facebook-www/ReactDOM-prod.classic.js
@@ -15469,7 +15469,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1742 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-70b0bbda7-20230221",
+  version: "18.3.0-www-classic-60144a04d-20230221",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2109 = {
@@ -15499,7 +15499,7 @@ var internals$jscomp$inline_2109 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
+  reconcilerVersion: "18.3.0-next-60144a04d-20230221"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15747,4 +15747,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
   );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-70b0bbda7-20230221";
+exports.version = "18.3.0-next-60144a04d-20230221";
diff --git a/compiled/facebook-www/ReactDOM-prod.modern.js b/compiled/facebook-www/ReactDOM-prod.modern.js
@@ -14998,7 +14998,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1701 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-70b0bbda7-20230221",
+  version: "18.3.0-www-modern-60144a04d-20230221",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2073 = {
@@ -15029,7 +15029,7 @@ var internals$jscomp$inline_2073 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
+  reconcilerVersion: "18.3.0-next-60144a04d-20230221"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2074 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15213,4 +15213,4 @@ exports.unstable_flushControlled = function (fn) {
   }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-70b0bbda7-20230221";
+exports.version = "18.3.0-next-60144a04d-20230221";
diff --git a/compiled/facebook-www/ReactDOM-profiling.classic.js b/compiled/facebook-www/ReactDOM-profiling.classic.js
@@ -16239,7 +16239,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1822 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-70b0bbda7-20230221",
+  version: "18.3.0-www-classic-60144a04d-20230221",
   rendererPackageName: "react-dom"
 };
 (function (internals) {
@@ -16283,7 +16283,7 @@ var devToolsConfig$jscomp$inline_1822 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
+  reconcilerVersion: "18.3.0-next-60144a04d-20230221"
 });
 assign(Internals, {
   ReactBrowserEventEmitter: {
@@ -16518,7 +16518,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
   );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-70b0bbda7-20230221";
+exports.version = "18.3.0-next-60144a04d-20230221";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (
diff --git a/compiled/facebook-www/ReactDOM-profiling.modern.js b/compiled/facebook-www/ReactDOM-profiling.modern.js
@@ -15758,7 +15758,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1781 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-70b0bbda7-20230221",
+  version: "18.3.0-www-modern-60144a04d-20230221",
   rendererPackageName: "react-dom"
 };
 (function (internals) {
@@ -15803,7 +15803,7 @@ var devToolsConfig$jscomp$inline_1781 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
+  reconcilerVersion: "18.3.0-next-60144a04d-20230221"
 });
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
 exports.createPortal = function (children, container) {
@@ -15974,7 +15974,7 @@ exports.unstable_flushControlled = function (fn) {
   }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-70b0bbda7-20230221";
+exports.version = "18.3.0-next-60144a04d-20230221";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (
diff --git a/compiled/facebook-www/ReactDOMServer-dev.classic.js b/compiled/facebook-www/ReactDOMServer-dev.classic.js
@@ -19,7 +19,7 @@ if (__DEV__) {
 var React = require("react");
 var ReactDOM = require("react-dom");
 
-var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");
diff --git a/compiled/facebook-www/ReactDOMServer-dev.modern.js b/compiled/facebook-www/ReactDOMServer-dev.modern.js
@@ -19,7 +19,7 @@ if (__DEV__) {
 var React = require("react");
 var ReactDOM = require("react-dom");
 
-var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");
diff --git a/compiled/facebook-www/ReactDOMServer-prod.classic.js b/compiled/facebook-www/ReactDOMServer-prod.classic.js
@@ -3670,4 +3670,4 @@ exports.renderToString = function (children, options) {
     'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
   );
 };
-exports.version = "18.3.0-www-classic-70b0bbda7-20230221";
+exports.version = "18.3.0-www-classic-60144a04d-20230221";
diff --git a/compiled/facebook-www/ReactDOMServer-prod.modern.js b/compiled/facebook-www/ReactDOMServer-prod.modern.js
@@ -3568,4 +3568,4 @@ exports.renderToString = function (children, options) {
     'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
   );
 };
-exports.version = "18.3.0-www-modern-70b0bbda7-20230221";
+exports.version = "18.3.0-www-modern-60144a04d-20230221";
diff --git a/compiled/facebook-www/ReactDOMTesting-dev.classic.js b/compiled/facebook-www/ReactDOMTesting-dev.classic.js
@@ -31233,7 +31233,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
 
 function createPortal$1(
   children,
diff --git a/compiled/facebook-www/ReactDOMTesting-dev.modern.js b/compiled/facebook-www/ReactDOMTesting-dev.modern.js
@@ -37624,7 +37624,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
 
 function createPortal$1(
   children,
diff --git a/compiled/facebook-www/ReactDOMTesting-prod.classic.js b/compiled/facebook-www/ReactDOMTesting-prod.classic.js
@@ -11541,7 +11541,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1536 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-70b0bbda7-20230221",
+  version: "18.3.0-www-classic-60144a04d-20230221",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2059 = {
@@ -11571,7 +11571,7 @@ var internals$jscomp$inline_2059 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
+  reconcilerVersion: "18.3.0-next-60144a04d-20230221"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2060 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14749,4 +14749,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
   );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-70b0bbda7-20230221";
+exports.version = "18.3.0-next-60144a04d-20230221";
diff --git a/compiled/facebook-www/ReactDOMTesting-prod.modern.js b/compiled/facebook-www/ReactDOMTesting-prod.modern.js
@@ -13856,7 +13856,7 @@ Internals.Events = [
 var devToolsConfig$jscomp$inline_1653 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-70b0bbda7-20230221",
+  version: "18.3.0-www-modern-60144a04d-20230221",
   rendererPackageName: "react-dom"
 };
 var internals$jscomp$inline_2033 = {
@@ -13887,7 +13887,7 @@ var internals$jscomp$inline_2033 = {
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
+  reconcilerVersion: "18.3.0-next-60144a04d-20230221"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2034 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14214,4 +14214,4 @@ exports.unstable_flushControlled = function (fn) {
   }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-70b0bbda7-20230221";
+exports.version = "18.3.0-next-60144a04d-20230221";
diff --git a/compiled/facebook-www/ReactTestRenderer-dev.classic.js b/compiled/facebook-www/ReactTestRenderer-dev.classic.js
@@ -23749,7 +23749,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
 
 // Might add PROFILE later.
 
diff --git a/compiled/facebook-www/ReactTestRenderer-dev.modern.js b/compiled/facebook-www/ReactTestRenderer-dev.modern.js
@@ -23749,7 +23749,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
+var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
 
 // Might add PROFILE later.
 

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-70b0bbda767ed016925889e8952b10f49921c0cf`
	`1`	`+60144a04da7970e30266f591dbcd67afe1097e41`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ if (`
`27`	`27`	`}`
`28`	`28`	`"use strict";`
`29`	`29`
`30`		`-var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";`
	`30`	`+var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";`
`31`	`31`
`32`	`32`	`// ATTENTION`
`33`	`33`	`// When adding new symbols to this file,`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {`
`69`	`69`	`return self;`
`70`	`70`	`}`
`71`	`71`
`72`		`-var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";`
	`72`	`+var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";`
`73`	`73`
`74`	`74`	`var LegacyRoot = 0;`
`75`	`75`	`var ConcurrentRoot = 1;`