Skip to content

Commit 07bedae

Browse files
committed
Exclude react-dom when flow checking other builds
This is because the HostConfig can't be guaranteed to be consistent with other code such as code that touches the DOM directly. Ideally we'd have a more systemic solution to this since it will pop up for other packages later too.
1 parent fd3e8cb commit 07bedae

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

scripts/flow/config/flowconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
.*/__mocks__/.*
1414
.*/__tests__/.*
1515

16+
%REACT_RENDERER_FLOW_IGNORES%
17+
1618
[include]
1719
../../../node_modules/
1820
../../../packages/

scripts/flow/createFlowConfigs.js

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,29 @@ function writeConfig(renderer, isFizzSupported) {
2323
mkdirp.sync(folder);
2424

2525
const fizzRenderer = isFizzSupported ? renderer : 'custom';
26-
const config = configTemplate.replace(
27-
'%REACT_RENDERER_FLOW_OPTIONS%',
28-
`
26+
const config = configTemplate
27+
.replace(
28+
'%REACT_RENDERER_FLOW_OPTIONS%',
29+
`
2930
module.name_mapper='react-reconciler/inline.${renderer}$$' -> 'react-reconciler/inline-typed'
3031
module.name_mapper='ReactFiberHostConfig$$' -> 'forks/ReactFiberHostConfig.${renderer}'
3132
module.name_mapper='react-stream/inline.${renderer}$$' -> 'react-stream/inline-typed'
3233
module.name_mapper='ReactFizzHostConfig$$' -> 'forks/ReactFizzHostConfig.${fizzRenderer}'
3334
module.name_mapper='ReactFizzFormatConfig$$' -> 'forks/ReactFizzFormatConfig.${fizzRenderer}'
3435
`.trim(),
35-
);
36+
)
37+
.replace(
38+
'%REACT_RENDERER_FLOW_IGNORES%',
39+
renderer === 'dom' || renderer === 'dom-browser'
40+
? ''
41+
: // If we're not checking DOM, ignore the DOM package since it
42+
// won't be consistent.
43+
`
44+
.*/packages/react-dom/.*
45+
.*/packages/.*/forks/.*.dom.js
46+
.*/packages/.*/forks/.*.dom-browser.js
47+
`.trim(),
48+
);
3649

3750
const disclaimer = `
3851
# ---------------------------------------------------------------#

0 commit comments

Comments
 (0)