Update on "[compiler][hir] Correctly remove non-existent terminal preds when pruning labels"

mofeiZ · mofeiZ · commit 01693b6ce05e · 2024-06-25T16:06:21.000-04:00
Missed this initially in `pruneUnusedLabelsHIR`. It wasn't an active bug as `preds` wasn't referenced by later passes, until #30079 [ghstack-poisoned]
diff --git a/compiler/packages/babel-plugin-react-compiler/src/HIR/PruneUnusedLabelsHIR.ts b/compiler/packages/babel-plugin-react-compiler/src/HIR/PruneUnusedLabelsHIR.ts
@@ -69,7 +69,7 @@ export function pruneUnusedLabelsHIR(fn: HIRFunction): void {
   }
 
   for (const [_, block] of fn.body.blocks) {
-    for (const pred of [...block.preds]) {
+    for (const pred of block.preds) {
       const rewritten = rewrites.get(pred);
       if (rewritten != null) {
         block.preds.delete(pred);

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ export function pruneUnusedLabelsHIR(fn: HIRFunction): void {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`for (const [_, block] of fn.body.blocks) {`
`72`		`- for (const pred of [...block.preds]) {`
	`72`	`+ for (const pred of block.preds) {`
`73`	`73`	`const rewritten = rewrites.get(pred);`
`74`	`74`	`if (rewritten != null) {`
`75`	`75`	`block.preds.delete(pred);`