Image Prefetching > Re-enable JNI batching for ImageFetcher #54486
+46
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86676643. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 10, 2025
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Differential Revision: D86676643
christophpurrer
force-pushed
the
export-D86676643
branch
from
43a4d03 to
5a728b4
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Differential Revision: D86676643
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Differential Revision: D86676643
christophpurrer
force-pushed
the
export-D86676643
branch
from
5a728b4 to
6d6bcf6
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86676643
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86676643
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86676643
christophpurrer
force-pushed
the
export-D86676643
branch
from
6d6bcf6 to
4711ba9
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86676643
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86676643
christophpurrer
force-pushed
the
export-D86676643
branch
from
4711ba9 to
7341b9a
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 12, 2025
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86676643
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 12, 2025
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86676643
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86676643
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 12, 2025
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86676643
christophpurrer
force-pushed
the
export-D86676643
branch
from
7341b9a to
47f6a75
Compare
|
This pull request has been merged in 5d0b0c8. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in 5d0b0c8 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases
Changelog: [Internal]
Differential Revision: D86676643