use latest infer-annotations from maven #20599
Conversation
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
✅Test Plan
Missing Changelog
|
Why can't i see android build ? |
|
@gengjiawen no idea, here is the link https://circleci.com/gh/dulmandakh/react-native/1349 |
|
GitHub sometimes fails to show all tests, but you can usually follow the link to Circle CI in order to see the entire workflow. |
|
@hramos I found that fresco and some other FB projects use infer-annotations from maven. Please review and merge. |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
Import Failed
and removed
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
|
This pull request was closed by @dulmandakh in f884a1b. Once this commit is added to a release, you will see the corresponding version tag below the description at f884a1b. If the commit has a single |
Summary: This PR removes infer-annotation from the repo and uses latest version of it from maven. Pull Request resolved: #20599 Differential Revision: D9437594 Pulled By: hramos fbshipit-source-id: 93c33041dd8a61b220c352fb187a23bb2dd1b4db
Summary: This PR removes infer-annotation from the repo and uses latest version of it from maven. Pull Request resolved: facebook#20599 Differential Revision: D9437594 Pulled By: hramos fbshipit-source-id: 93c33041dd8a61b220c352fb187a23bb2dd1b4db
Summary: This PR removes infer-annotation from the repo and uses latest version of it from maven. Pull Request resolved: facebook#20599 Differential Revision: D9437594 Pulled By: hramos fbshipit-source-id: 93c33041dd8a61b220c352fb187a23bb2dd1b4db
Summary: This PR removes infer-annotation from the repo and uses latest version of it from maven. Pull Request resolved: facebook#20599 Differential Revision: D9437594 Pulled By: hramos fbshipit-source-id: 93c33041dd8a61b220c352fb187a23bb2dd1b4db
Summary: This PR removes infer-annotation from the repo and uses latest version of it from maven. Pull Request resolved: facebook#20599 Differential Revision: D9437594 Pulled By: hramos fbshipit-source-id: 93c33041dd8a61b220c352fb187a23bb2dd1b4db
This PR removes infer-annotation from the repo and uses latest version of it from maven.
Test Plan:
Everything builds and runs as normal